Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove eval() python method #265

Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix: remove eval() python method #265

merged 2 commits into from
Apr 15, 2024

Conversation

michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

  • Removed eval() python function for retrieving the correct class from the configs, replaced with hydra.utils.get_class().
  • Removed eval() python function in the DiambraWrapper, replaced with the getattr() python metod.

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@belerico belerico merged commit 31a8e9b into main Apr 15, 2024
12 checks passed
@belerico belerico deleted the fix/remove-eval branch April 16, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants