Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added prepare obs to all the algorithms #267

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Conversation

michele-milesi
Copy link
Member

@michele-milesi michele-milesi commented Apr 17, 2024

Summary

Describe the purpose of the pull request, including:

  • Added a prepare_obs() function for each algorithm.
  • The goal is to standardize the environment interaction for diambra submissions. We can keep it as an interim solution pending the handling of this aspect directly in the encoder.

EDIT:

  • The process_obs function is used both during training and test.

Type of Change

Please select the one relevant option below:

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

DavideTr8
DavideTr8 previously approved these changes Apr 17, 2024
@belerico belerico enabled auto-merge (squash) April 19, 2024 15:20
@belerico belerico merged commit 5298755 into main Apr 20, 2024
12 checks passed
@michele-milesi michele-milesi deleted the feature/preprocess-obs branch April 24, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants