Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/timer metrics #283

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix/timer metrics #283

merged 2 commits into from
May 9, 2024

Conversation

michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

@michele-milesi michele-milesi linked an issue May 9, 2024 that may be closed by this pull request
Copy link
Member

@belerico belerico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, it's still strange to me how it's possible that an algorithm has a train time of exaclty 0s...

howto/register_external_algorithm.md Show resolved Hide resolved
@belerico belerico merged commit 75d752f into main May 9, 2024
12 checks passed
@belerico belerico deleted the fix/timer_metrics branch May 9, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dreamer division by 0 crash
2 participants