Improve Etherscan data fetching reliability #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes made: 1. Added etherscanAddress validation alongside apiKey check 2. Improved error handling in Promise.all with detailed error messages 3. Added response status checks for all API requests 4. Enhanced error handling in catch block with cache fallback 5. Fixed interface formatting (removed extra space in ICache) 6. Added detailed error reporting for failed API requests 7. Improved code formatting and readability 8. Added proper error message when API requests fail 9. Enhanced type safety for API responses The changes make the code more robust by: - Validating all required configuration parameters - Providing more detailed error messages - Implementing proper fallback to cached data - Adding better error handling for API responses - Improving overall code structure and readability
|
@savvar9991 is attempting to deploy a commit to the Eclipse Labs Team on Vercel. A member of the Team first needs to authorize it. |
add Etherscan API endpoint for bridge deposits tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache Implementation
Impact