Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kyle/continue redeem teth #152

Open
wants to merge 20 commits into
base: eclipse-apps
Choose a base branch
from

Conversation

knoll3
Copy link

@knoll3 knoll3 commented Dec 5, 2024

Continues work on tETH redeem.

  • Added bridge fee
  • Transaction modal state resets when restarting transactions
  • Added pending transactions tab
  • Updated transaction order for redeem

Important for Eclipse team: This PR downgrades the @coral-xyz/anchor library from 0.30 to 0.29 in order to be compatible with the @hyperlane-xyz/sdk, which is required for bridging to and from Eclipse. There seem to be a few util functions outside of our nucleus functionality that use the@coral-xyz/anchor library. I would request that the hyperlane team test this functionality before merging this PR. In the mean time we are working with the hyperlane team to find a more ideal solution.

Also for Eclipse team: I also added polyfills to next.config.js to handle some Node.js specific modules that hyperlane is using directly or indirectly. We are also working with them on this. This should not have an impact on other parts of the app, I just want to make you aware.

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app.eclipse.xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 2:22am
eclipse-bridge-ux ❌ Failed (Inspect) Dec 19, 2024 2:22am
teth-mint ❌ Failed (Inspect) Dec 19, 2024 2:22am

Copy link

vercel bot commented Dec 5, 2024

@knoll3 is attempting to deploy a commit to the Eclipse Labs Team on Vercel.

A member of the Team first needs to authorize it.

@junkim012
Copy link

Screenshot 2024-12-06 at 9 14 19 PM

Even though the order was cancelled, each transaction in the steps succeeded, so it should still say "Done".

@junkim012
Copy link

IMAGE 2024-12-06 21:17:52
IMAGE 2024-12-06 21:17:55

The dollar value of tETH changes depending on which asset is chosen.

@junkim012
Copy link

Screenshot 2024-12-06 at 9 18 40 PM

In the transaction history, step 3. should also be 'Done', since the transaction itself succeeded.

@junkim012
Copy link

Screenshot 2024-12-06 at 9 21 09 PM

When I deny the first transaction, the app continues to prompt me through steps 2 and step 3.
If any of the transactions are denied, the entire process should be aborted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants