-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kyle/continue redeem teth #152
Open
knoll3
wants to merge
20
commits into
Eclipse-Laboratories-Inc:eclipse-apps
Choose a base branch
from
knoll3:kyle/continue-redeem-teth
base: eclipse-apps
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kyle/continue redeem teth #152
knoll3
wants to merge
20
commits into
Eclipse-Laboratories-Inc:eclipse-apps
from
knoll3:kyle/continue-redeem-teth
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@knoll3 is attempting to deploy a commit to the Eclipse Labs Team on Vercel. A member of the Team first needs to authorize it. |
knoll3
force-pushed
the
kyle/continue-redeem-teth
branch
from
December 7, 2024 05:09
b9c6045
to
662f2ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work on tETH redeem.
Important for Eclipse team: This PR downgrades the
@coral-xyz/anchor
library from0.30
to0.29
in order to be compatible with the@hyperlane-xyz/sdk
, which is required for bridging to and from Eclipse. There seem to be a few util functions outside of our nucleus functionality that use the@coral-xyz/anchor
library. I would request that the hyperlane team test this functionality before merging this PR. In the mean time we are working with the hyperlane team to find a more ideal solution.Also for Eclipse team: I also added polyfills to
next.config.js
to handle some Node.js specific modules that hyperlane is using directly or indirectly. We are also working with them on this. This should not have an impact on other parts of the app, I just want to make you aware.