Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

#312: Add pagination to the github/{id}/events endpoint #320

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

pacyL2K19
Copy link

Fixes Issue

Closes #312

Changes proposed

Added pagination feature, added a UtilsModule for shared logic, currently with a simple pagination service file, can be extended with complex shared logic in the future

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@pacyL2K19 pacyL2K19 changed the title #312: Add pagination to thegithub/{id}/events endpoint #312: Add pagination to the github/{id}/events endpoint May 21, 2024
@pacyL2K19
Copy link
Author

@eddiejaoude please have a look
Looking forward to getting feedback from you and contributing more on the project

Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

I don't think changes to the lock file are required?

@pacyL2K19
Copy link
Author

Thanks for contributing!

I don't think changes to the lock file are required?

They weren't required
My bad, the change came after an npm install I can revert it

@pacyL2K19
Copy link
Author

Thanks for contributing!

I don't think changes to the lock file are required?

I just checked, don't you think it's fine to let it match the version we have in the package.json file?
This auto updated when I ran the install command, please let me know if I should revert this change or keep the old version
@eddiejaoude

@eddiejaoude
Copy link
Member

After merging the versions will be updated. Unless making changes to the package.json file, we must use npm ci so it uses the lock file and doesn't update it

@eddiejaoude eddiejaoude changed the base branch from main to contributions June 10, 2024 20:07
@eddiejaoude eddiejaoude merged commit b37cef7 into EddieHubCommunity:contributions Jun 10, 2024
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Pagination to /github/{id}/events
2 participants