Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 2.x #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support for 2.x #49

wants to merge 3 commits into from

Conversation

charleswong28
Copy link

@charleswong28 charleswong28 commented Aug 4, 2018

ref: issue 43

  • Added 3 folders for 1.x, 2.0.0, 2.3.3 at root. Hope it will be easier for the others to find.
  • Modified the code structure a bit to help debug easier.
  • I've disabled objectCaching for the text since when the group is scaled, the cache is not updated and the text will look blurry. This may not be a good solution. Look forward if someone is familiar with fabricjs 2.0 cache mechanism to modify it.
  • Save and reload from JSON is not working on this pull request. I saw there is another pull request on this.

ref: issue 26

  • Added globalCompositeOperation in delegatedProperties.

Compatible to 2.3.3
loadFromJSON function is not fixed yet. Save / reload button is not working
Fix largetosmall and smalltolarge top alignment issue
@c-gross
Copy link

c-gross commented Aug 10, 2018

Just tested your version for 2.3.3 . It's working but I have one issue.
I implemented some position horizontal center method to my text elements whichw as working with old fabric 1.5.0 and is also working in the lastest version. I was working with this curved extension in 1.5.0 but in 2.3.4 and this version of the extension the text is moving a little bit right.

item.set('left', config.pos_x - item.getScaledWidth() * Math.cos(angleRad) / 2);

Any idea why the calculation does not work for this version?

@charleswong28
Copy link
Author

I also realized the padding of the curved text and the sharpness of the text are not the same in 1.x and 2.3.3 version. I believe the text class is modified in fabric 2.x and that's why the result is not the same.

Will look into this later when I have time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants