New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend 'Derivs' to cover 6th and 8th order finite difference #307

Open

lwJi wants to merge 15 commits into main from lwji/derivs

Contributor

lwJi commented Sep 8, 2024 •

edited

Loading

Derivs:

implement 6th and 8th order accurate central finite difference.
implement dissipation and upwind derivatives corresponding to 6th and 8th order central finite difference.

TestDerivs:

implement unit test for all above.

all the coefficients used are calculated here using mathematica
https://github.com/lwJi/Docs-Subcycling/blob/main/wolfram/Derivs.ipynb

lwJi requested review from eschnett and rhaas80

September 8, 2024 21:57

lwJi force-pushed the lwji/derivs branch from 040d80b to 516cbdf Compare

October 23, 2024 21:08

Member

rhaas80 commented Oct 28, 2024

Fails in SYCL build due to calls via function pointer:

https://github.com/EinsteinToolkit/CarpetX/actions/runs/11491459037/job/31983862784?pr=307#step:6:5364

needs changes.

rhaas80 self-assigned this

rhaas80 requested changes

View reviewed changes

Member

rhaas80 left a comment

Fails due to compile for SYCL due to calls via function pointer:

https://github.com/EinsteinToolkit/CarpetX/actions/runs/11491459037/job/31983862784?pr=307#step:6:5364

probably also would fail (at runtime) for CUDA.

Contributor Author

lwJi commented Oct 28, 2024

Fails due to compile for SYCL due to calls via function pointer:

https://github.com/EinsteinToolkit/CarpetX/actions/runs/11491459037/job/31983862784?pr=307#step:6:5364

probably also would fail (at runtime) for CUDA.

I have remove the usage of function pointer, please take another look

eschnett reviewed

View reviewed changes

Derivs/src/derivs.cxx Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

Derivs/src/derivs.cxx Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

Derivs/src/derivs.cxx Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

Derivs/src/derivs.cxx Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

TestDerivs/interface.ccl Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

TestDerivs/src/test.cxx Outdated Show resolved Hide resolved

eschnett reviewed

View reviewed changes

TestDerivs/src/test.cxx Outdated Show resolved Hide resolved

Contributor Author

lwJi commented Oct 28, 2024

Hi @eschnett @rhaas80, I have addressed the comments in the above few commits. Thanks

rhaas80 requested changes

View reviewed changes

Derivs/src/derivs.cxx Show resolved Hide resolved

Derivs/src/derivs.cxx Show resolved Hide resolved

TestDerivs/param.ccl Show resolved Hide resolved

TestDerivs/src/test.cxx Outdated Show resolved Hide resolved

TestDerivs/src/test.cxx Show resolved Hide resolved

TestDerivs/src/test.cxx Show resolved Hide resolved

Contributor Author

lwJi commented Oct 31, 2024

Hi @rhaas80, I think I have addressed all your comments in the recent few commits. please take another look. Thanks

lwJi force-pushed the lwji/derivs branch from c34a7f3 to 823f009 Compare

November 2, 2024 03:53

lwJi added 12 commits

November 19, 2024 15:45


          Derivs: add support for 6th and 8th order accurate finite difference

f01abc1


          TestDerivs: add unit test for finite difference, dissipation, upwind …

5245e5b

…up to 8th order


          TestDerivs: remove used data files

696f6d7


          TestDerivs: remove Arith:: for cos

2f1ea3e


          TestDerivs: remove usage of funciton pointer

e21cbca


          TestDerivs: update derivs-8th-order.par for unit test

a1fe6bc


          Derivs: fix comment 'Take ghost points into account'

7b603c1


          Derivs: replace deriv_order with its value inside kernel

243ba5d


          TestDerivs: beautify interface.ccl

2da976c


          TestDerivs: beautify test.cxx

d70b8f1


          TestDerivs: remove leftover std::sin

94de9f7


          TestDerivs: replace assert(0) with abort inside kernel

99d3331

lwJi added 3 commits

November 19, 2024 15:45


          TestDerivs: pass integer for pown

d421b85


          TestDerivs: add using std::sin

23f2f04


          TestDerivs: replace abort() since it doesn't work on device

cdceed4

lwJi force-pushed the lwji/derivs branch from aea6d89 to cdceed4 Compare

November 19, 2024 20:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet