CarpetX: only use BLOSC2 if compiled into ADIOS2 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaas80
force-pushed
the
rhaas/noblosc
branch
from
9afc540
to
91535d2
Compare
eschnett
approved these changes
Nov 2, 2024
|
I approve. (The Bitbucket issue page doesn't load for me at the moment.) |
|
Thank you. |
lwJi
added a commit
to lwJi/CarpetX
that referenced
this pull request
Nov 15, 2024
* CI: Update to AMReX 24.09 * Arith: Implement efficient SIMD trigonometic functions * Arith: Correct SIMD tests * Arith: Correct SIMD tests * Arith: Remove `constexpr` that some compilers don't like * Arith: Remove `constexpr` that some compilers don't like * TestDerivs: Correct C++ calls to trigonometic functions * CI: Disable SIMD the new way * CI: Update Docker images * CI: Correct Docker image names * CarpetX: Update to nvtx3 * CI: Reduce optimization level for OneAPI * CI: Switch to production images * CarpetXRegrid: Move regrid_error to a new thorn. * CI: Add CarpetXRegrid to thorn list * CarpetX: Change the implementation to Driver This involves adding a parameter "periodic" whose default value is "no." It also involves modifying parameter files, file names, and source files where the name "CarpetX" needs to be replaced by "Driver." * Algo: remove parameter file and changing data from test output * BenchX: sort thorns alphabetically * BenchX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * BoxInBox: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * ErrorEstimator: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * FluxWaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * MovingBoxToy: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * PoissonX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * SiMDWaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * SpacetimeWaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * StaggeredWaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestArrayGroup: remove parameter file and changing data from test output * TestBoundaries: adapt to moving regrid error into its own thorn * TestBoxInBox: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestDerivs: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestInterpolate: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestLoopX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestNorms: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestODESolvers: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestODESolvers2: remove parameter file and changing data from test output * TestOutput: adapt to moving regrid error into its own thorn * TestProlongate: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestSymmetries: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * WaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * ODESolvers: Schedule `ODESolvers_PostStep` after recovering * Loop: Update AMReX include files * ADMBaseX: Clean up schedule * HydroBaseX: Clean up schedule * CarpetX: Correct ENO operators * CarpetX: Correct ENO operators * CarpetX: Correct poison check on HIP systems * CarpetX: Implement `minmod` prolongation operator * CarpetX: Support openPMD_api 0.16.0 * CarpetX: Use Blosc compression by default for openPMD output * CarpetX: Reformat code * CarpetX: ADIOS2: Avoid too much screen output * CarpetX: ADIOS2: Use Blosc compression by default * Arith: Clean up code * BoxInBox: Don't allow zero radius * Loop: Inline more aggressively * MovingBoxToy: Code cleanup * TestSymmetries: Beautify code * Loop: New macro CCTK_KERNEL * CI: Update Docker images * FluxWaveToyX: Correct RHS handling after ODESolver update * SIMDWaveToyX: Correct RHS handling after ODESolver update * WaveToyX: Correct RHS handling after ODESolver update * StaggeredWaveToyX: Correct RHS handling after ODESolver update * CI: Update Docker images to AMReX 24.11 * FluxWaveToyX: Correct schedule and test output * TestODESolvers: Correct schedule * TestProlongate: Remove unsupporte 1st-order ENO operators * CarpetX: only use BLOSC2 if compiled into ADIOS2 (EinsteinToolkit#314) * CarpetX: Reduce termination condition Reduce the final termination condition, not just the run time. This guarantees that all processes will terminate at the same iteration. * CarpetX: Correct error check in interpolator * CarpetX: Simplify error output in interpolator * CarpetX: Slight performance improvement in interpolator * CarpetX: Improve safety/reduce warnings in interpolator * TestInterpolate: Test cell-centred interpolation * Loop: explicitly create function args to avoid compiler issue * ODESolvers: rename CarpetX to Driver * Subcycling: rename CarpetX to Driver * TestDerivs: remove Arith:: for cos * TestSubcyclingMC: rename CarpetX to Driver * TestSubcyclingMC2: remove INHERITS: CarpetX * TestDerivs: update derivs-8th-order.par * TestSubcycling: change implementation to Driver * TestSubcycling: change implementation to Driver * TestSubcyclingMC2: change implementation to Driver --------- Co-authored-by: Erik Schnetter <[email protected]> Co-authored-by: Steven R. Brandt <[email protected]> Co-authored-by: Roland Haas <[email protected]>
lwJi
added a commit
to lwJi/CarpetX
that referenced
this pull request
Nov 15, 2024
* CI: Update to AMReX 24.09 * Arith: Implement efficient SIMD trigonometic functions * Arith: Correct SIMD tests * Arith: Correct SIMD tests * Arith: Remove `constexpr` that some compilers don't like * Arith: Remove `constexpr` that some compilers don't like * TestDerivs: Correct C++ calls to trigonometic functions * CI: Disable SIMD the new way * CI: Update Docker images * CI: Correct Docker image names * CarpetX: Update to nvtx3 * CI: Reduce optimization level for OneAPI * CI: Switch to production images * CarpetXRegrid: Move regrid_error to a new thorn. * CI: Add CarpetXRegrid to thorn list * CarpetX: Change the implementation to Driver This involves adding a parameter "periodic" whose default value is "no." It also involves modifying parameter files, file names, and source files where the name "CarpetX" needs to be replaced by "Driver." * Algo: remove parameter file and changing data from test output * BenchX: sort thorns alphabetically * BenchX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * BoxInBox: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * ErrorEstimator: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * FluxWaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * MovingBoxToy: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * PoissonX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * SiMDWaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * SpacetimeWaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * StaggeredWaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestArrayGroup: remove parameter file and changing data from test output * TestBoundaries: adapt to moving regrid error into its own thorn * TestBoxInBox: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestDerivs: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestInterpolate: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestLoopX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestNorms: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestODESolvers: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestODESolvers2: remove parameter file and changing data from test output * TestOutput: adapt to moving regrid error into its own thorn * TestProlongate: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * TestSymmetries: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * WaveToyX: adapt to CarpetX implementation change required due to CarpetX implemting "Driver" * ODESolvers: Schedule `ODESolvers_PostStep` after recovering * Loop: Update AMReX include files * ADMBaseX: Clean up schedule * HydroBaseX: Clean up schedule * CarpetX: Correct ENO operators * CarpetX: Correct ENO operators * CarpetX: Correct poison check on HIP systems * CarpetX: Implement `minmod` prolongation operator * CarpetX: Support openPMD_api 0.16.0 * CarpetX: Use Blosc compression by default for openPMD output * CarpetX: Reformat code * CarpetX: ADIOS2: Avoid too much screen output * CarpetX: ADIOS2: Use Blosc compression by default * Arith: Clean up code * BoxInBox: Don't allow zero radius * Loop: Inline more aggressively * MovingBoxToy: Code cleanup * TestSymmetries: Beautify code * Loop: New macro CCTK_KERNEL * CI: Update Docker images * FluxWaveToyX: Correct RHS handling after ODESolver update * SIMDWaveToyX: Correct RHS handling after ODESolver update * WaveToyX: Correct RHS handling after ODESolver update * StaggeredWaveToyX: Correct RHS handling after ODESolver update * CI: Update Docker images to AMReX 24.11 * FluxWaveToyX: Correct schedule and test output * TestODESolvers: Correct schedule * TestProlongate: Remove unsupporte 1st-order ENO operators * CarpetX: only use BLOSC2 if compiled into ADIOS2 (EinsteinToolkit#314) * CarpetX: Reduce termination condition Reduce the final termination condition, not just the run time. This guarantees that all processes will terminate at the same iteration. * CarpetX: Correct error check in interpolator * CarpetX: Simplify error output in interpolator * CarpetX: Slight performance improvement in interpolator * CarpetX: Improve safety/reduce warnings in interpolator * TestInterpolate: Test cell-centred interpolation * Loop: explicitly create function args to avoid compiler issue --------- Co-authored-by: Erik Schnetter <[email protected]> Co-authored-by: Steven R. Brandt <[email protected]> Co-authored-by: Roland Haas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.