Unify derivatives between CarpetX and SpacetimeX. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) Discard existing derivs.hxx and derivs.cxx (2) Merge z4c and weyl derivs.hxx (3) move epsdiss to Derivs
eschnett
requested changes
May 27, 2023
| @@ -695,7 +695,8 @@ Numerical/AEILocalInterp | |||
| # CarpetX thorns | |||
| !TARGET = $ARR | |||
| !TYPE = git | |||
| !URL = https://github.com/eschnett/CarpetX.git | |||
There was a problem hiding this comment.
This is convenient for testing, but this shouldn't be merged.
| @@ -15,6 +15,10 @@ USES INCLUDE HEADER: ten3.hxx | |||
| USES INCLUDE HEADER: vec.hxx | |||
| USES INCLUDE HEADER: vect.hxx | |||
|
|
|||
| INHERITS: Derivs | |||
There was a problem hiding this comment.
INHERITS is for grid functions, but we don't need any grid functions from Derivs.
To ensure that the derivative operators are actually present, thorn Derivs needs to provide a capability Derivs, and thorns Weyl and Z4c need to requires that derivative. Both are handled in the respective configuration.ccl files.
There was a problem hiding this comment.
This is already done.
eschnett
requested changes
May 27, 2023
| @@ -695,7 +695,8 @@ Numerical/AEILocalInterp | |||
| # CarpetX thorns | |||
| !TARGET = $ARR | |||
| !TYPE = git | |||
| !URL = https://github.com/eschnett/CarpetX.git | |||
There was a problem hiding this comment.
Can you split this into three pull requests instead of two?
- Add new capabilities (and tests) to thorn
Derivs - Switch over thorns
WeylandZ4c - Clean up
CarpetX
This will allow the changes to be tested and reviewed independently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Discard existing derivs.hxx and derivs.cxx
(2) Merge z4c and weyl derivs.hxx
(3) move epsdiss to Derivs