Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some people show up multiple times #2

Open
Zombie-Ryushu opened this issue Aug 2, 2016 · 7 comments
Open

Some people show up multiple times #2

Zombie-Ryushu opened this issue Aug 2, 2016 · 7 comments

Comments

@Zombie-Ryushu
Copy link

Some people show up multiple times in Yahoo. Two or three Copies of the same person appear, with the same name or ID.

@EionRobb
Copy link
Owner

EionRobb commented Aug 4, 2016

This 'might' have been fixed in f60b3e1 which was trying to add the "yahoo" group to the buddy list multiple times

@wolfy67
Copy link
Contributor

wolfy67 commented Aug 19, 2016

I see the same problem, using 48430a3

@rhester72
Copy link

rhester72 commented Aug 22, 2016

Ditto - in Bitlbee, all show up under 'yahoocom' (by login/e-mail address) under 'eionrobb-funyahoo-plusplus' (by Yahoo nickname). More interestingly, my own Yahoo account shows up twice - apparently I message myself frequently ;)

Very interestingly, the 'mirrors' of the users show up with entirely different "hex IDs".

@alexolog
Copy link

alexolog commented Sep 4, 2016

I think it's one of the issues I mentioned in #19

@msdobrescu
Copy link

I have this, but just one of the three actually works for chatting.

@EionRobb
Copy link
Owner

This looks like it's to do with the way we rename users in the buddy list.

When you add a buddy, eg with their old yahoo messenger ID, it goes through a few renames on the server to get a temporary Base32 ID and end up with the actual Base32 ID. There's potential there to end up with duplicates in the ~/.purple/blist.xml file depending on the order of events coming back from the server - but only one of the dups will have the 'groupId' setting and thus only one dup will be able to have messages sent to them.

Instead of doing a buddy list rename, we should be doing a conversation rename, and removing the old buddy and re-adding the new one. Perhaps storing a list of temporary buddy ids temporarily to not store the bad buddys to the buddy list?

@Bearded-Blunder
Copy link

my own Yahoo account shows up twice - apparently I message myself frequently ;)

I'll see your twice, and raise you three times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants