Feature branch for 0.5.0 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables development on non-Apple machines, and potentially in future usage of the Swift SDK with non-Apple targets.
Conditionally compile Apple-specific APIs
Replace Sapling balance and scan progress FFIs with wallet summary FFI
This removes the type system separation between pre-ZIP 313 and ZIP 317 fees, which becomes necessary when using the transaction proposal protobuf encoder.
Migrate to latest in-progress revision of Rust crates
…al-based methods Closes #86.
Closed
Replace `zcashlc_create_to_address, zcashlc_shield_funds` with proposal-based methods
pacu
suggested changes
Jan 23, 2024
| /// - The total size `len` must be no larger than `isize::MAX`. See the safety | ||
| /// documentation of `pointer::offset`. | ||
| #[repr(C)] | ||
| pub struct FfiBoxedSlice { |
There was a problem hiding this comment.
If "Its contents must be an encoded Proposal protobuf" shouldn't this have a meaningful name indicating this so that it's not used for other purposes?
There was a problem hiding this comment.
I think I added that line to the documentation before I decided to implement this as an FfiBoxedSlice. I think it's better to just remove that requirement and allow this to contain an arbitrary byte slice, the contents of which is determined by the method it is returned from.
These changes include performance improvements for scanning.
[#114] Create a transaction proposal from ZIP-321 payment URI
…pdates Performance and summary updates
str4d
commented
Jan 29, 2024
| chain_tip_height: i32, | ||
| fully_scanned_height: i32, | ||
| scan_progress: *mut FfiScanProgress, | ||
| next_sapling_subtree_index: u64, |
There was a problem hiding this comment.
The protobuf constrains this to a u32, so we should do that here as well. I'll fix this in the next PR.
…0.5.0 Final Rust dependency update for 0.5.0
str4d
commented
Jan 30, 2024
nuttycom
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.