Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to librustzcash version 0.7 #32

Merged
merged 60 commits into from
Nov 16, 2022
Merged

Update to librustzcash version 0.7 #32

merged 60 commits into from
Nov 16, 2022

Conversation

nuttycom
Copy link
Contributor

No description provided.

pacu and others added 25 commits August 24, 2022 10:34
@pacu @nuttycom
Require the caller to consistently provide a number of confirmations.
2918091
@nuttycom
Improve use of unsafe and fix clippy complaints.
ccae3ca 
This modifies our use of `unsafe` to prefer unsafe blocks to
fully unsafe function declarations, to make it easier to see what
operations are actually unsafe within a function, and then adds
safety documentation as appropriate.
@nuttycom
Reuse FFIUVKBoxedSlice for all FFI methods where we return a Vec<String>
5c38d29 
This avoids potentially undefined behavior related to previous use
of std::mem::forget
@nuttycom
Update to librustzcash version that includes Orchard key generation.
6d5b16c
@nuttycom @daira
Fix documentation related to struct alignment.
ff04662 
Co-authored-by: Daira Hopwood <[email protected]>
@nuttycom
Merge pull request #38 from nuttycom/librustzcash_0_7-fix_mem_forget
9b6d111 
Fix undefined behavior in zcashlc_init_accounts_table result.
@pacu @nuttycom
Remove Spending key from arguments to shield_funds.
f170347
@pacu @nuttycom
Add FFI function to validate spending key `zcashlc_is_valid_sapling_e…
d7d2ab9 
…xtended_spending_key`
@nuttycom
Merge pull request #31 from zcash-hackworks/shield_funds_to_zip_316
6ffdf7a 
Remove Spending key from `shield_funds`
@pacu @nuttycom
[#26] make FFI accept byte slices for memos
014dc55 
Closes #26

This implements changes to FFI functions `zcashlc_shield_funds`
and `zcashlc_create_to_address` to accept Memos as slices of
bytes instead of a null-terminated UTF-8 char array.

The receiving functions will attempt to parse the receiving
bytes as ZIP-302 compliant and will fail if the rust side
fails to parse create `MemoBytes` from the respective `[u8]`.

Add support for type safe memos by retrieving them as bytes with
`zcashlc_get_received_memo`
`zcashlc_get_sent_memo`
`zcashlc_byte_array_free`

These functions will have to be adopted by the RustWelding layer on
ZcashLightClientKit
@nuttycom @str4d
Apply suggestions from code review
84fe7aa 
Co-authored-by: str4d <[email protected]>
@nuttycom
Clarify db_data string documentation.
41adf69
@nuttycom
Merge pull request #27 from zcash-hackworks/make-memos-great-again
6a95020 
[#26] make FFI accept byte slices for memos
@nuttycom
Change memo parameters back to *const u8
d6b0218 
Swift lacks fixed-size arrays, so this change makes for a cleaner
API on the Swift side, at the expense of slightly less type safety
in the C api.
@nuttycom
Change memo parameters back to *const u8 (#42)
b968007
@nuttycom
Use *mut u8 pointers for memo return.
e82feac
@pacu
Merge pull request #44 from nuttycom/swift_friendly_memos
d29c1f5 
Swift friendly memos
@str4d
Add FFI method to access transparent receiver of UA
4d34d17
@str4d
Merge pull request #46 from zcash-hackworks/ua-access-transparent-rec…
bd08ada 
…eiver

Add FFI method to access transparent receiver of UA
@str4d
Add FFI method to extract typecodes of a UA's receivers
94d626d
@str4d
Add links to ZIP 316 about how to interpret typecodes
49084ee
@nuttycom
Merge pull request #47 from zcash-hackworks/ua-extract-receiver-typec…
ae26b76 
…odes

Add FFI method to extract typecodes of a UA's receivers
@nuttycom
Use unified spending keys instead of Sapling extended spending keys.
2951880 
This also updates `zcashlc_create_to_address` to take a unified spending
key for spending authority instead of a Sapling extended spending key.
Also, the unified spending key is now required for shielding.  This
removes the need to separately derive the transparent spending key, and
provides overall a more consistent API experience, such that the caller
always works in terms of a single, opaque, binary representation of the
spending key.

This also removes direct derivation of addresses from the seed, spending
key, and viewing key, in favor of using the wallet backend to manage
addresses. This is necessary to ensure that diversified addresses
produced by this API are properly recorded in the wallet database, so
that the transparent receivers associated with newly derived diversified
addresses can be correctly monitored for incoming funds.

After this change, the direct dependency on hdwallet is no longer needed.
@nuttycom @pacu
Update CHANGELOG.md
a6de2eb 
Co-authored-by: Francisco Gindre <[email protected]>
@nuttycom
Merge pull request #45 from nuttycom/librustzcash_0_7-usk_encoding
f1df12b
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Outdated Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Outdated Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Outdated Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Outdated Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/Cargo.toml Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Show resolved Hide resolved
daira
daira reviewed Nov 15, 2022
View reviewed changes
rust/src/lib.rs Show resolved Hide resolved
@daira
Copy link
Contributor

daira commented Nov 15, 2022

This PR isn't compiling for me. Is cd rust; cargo check intended to work?

@sellout
Copy link
Contributor

sellout commented Nov 15, 2022

This PR isn't compiling for me. Is cd rust; cargo check intended to work?

Yikes. It is certainly not compiling. I didn’t realize this repo doesn’t have any checks, and the build instructions in the README aren’t very helpful. E.g., make && make install doesn’t even build the package and make xcframework is macOS-specific. I’ll follow-up this PR with build & CI improvements. Looks like that’s already issue #2.

daira
daira approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo comments.

rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Outdated Show resolved Hide resolved
@sellout sellout self-assigned this Nov 16, 2022
@sellout sellout merged commit 1fae84c into main Nov 16, 2022
@sellout sellout deleted the librustzcash_0_7 branch November 16, 2022 03:46
@sellout sellout restored the librustzcash_0_7 branch November 16, 2022 06:19
daira
daira reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc utACK 2096654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d left review comments

@daira daira daira approved these changes

@sellout sellout sellout left review comments

@pacu pacu pacu approved these changes

Assignees

@sellout sellout

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nuttycom @pacu @daira @sellout @str4d