Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to librustzcash version 0.7, take 2 #66

Merged
merged 8 commits into from
Nov 16, 2022
Merged

Update to librustzcash version 0.7, take 2 #66

merged 8 commits into from
Nov 16, 2022

Conversation

sellout
Copy link
Contributor

@sellout sellout commented Nov 16, 2022 •
edited by daira
Loading

First time I failed to include the ZIP 317 changes in the feature branch.
closes #65

@sellout sellout requested review from pacu, daira and str4d November 16, 2022 16:47
@sellout
Copy link
Contributor Author

sellout commented Nov 16, 2022

These changes are identical to #63. That PR has approval from @daira, @pacu, and @str4d. So if one of you could approve this with a message that says it’s fine to carry over those approvals, I can merge this quickly.

pacu
pacu suggested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this repeated code?

rust/src/lib.rs Show resolved Hide resolved
@daira
Copy link
Contributor

daira commented Nov 16, 2022

#67 fixes issues with unsafe annotations (and #65).

daira
daira approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. (Consider including #67, but it's fine to do that separately.)

@daira daira mentioned this pull request Nov 16, 2022
Closed
daira
daira approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review after merges: utACK d305bb7

pacu
pacu approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@pacu pacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested autoshielding confirmations seem to be fine.

@pacu pacu merged commit 8fd64cb into main Nov 16, 2022
@pacu pacu deleted the librustzcash_0_7 branch November 16, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@pacu pacu pacu approved these changes

@str4d str4d Awaiting requested review from str4d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable the deny(unsafe_op_in_unsafe_fn) lint everywhere in zcash-light-client-ffi we define unsafe functions
5 participants
@sellout @daira @pacu @str4d @nuttycom