Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clightning: use CLN's listpeerchannels instead #300

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

YusukeShimizu
Copy link
Contributor

@YusukeShimizu YusukeShimizu commented Jul 7, 2024

The channels field was removed from listpeers in CLN v24.05.
This means that the peerswap-listpeers command also does not have this field.

Ensure that listchannels are used so that they are still visible in CLN v24.05 and later.
This is a backwards-compatible change that will continue to be displayed in CLN v24.05 and earlier.

Confirmed to work with v24.05 and v23.11.

Fixes #299.

The channels field was removed from listpeers in CLN v24.05.
This means that the peerswap-listpeers command also
does not have this field.

Instead, listpeerchannels is used to retrieve channels.
@YusukeShimizu YusukeShimizu marked this pull request as ready for review July 7, 2024 05:04
@grubles
Copy link
Collaborator

grubles commented Jul 7, 2024

Tested ACK dd78a61.

@YusukeShimizu YusukeShimizu requested a review from nepet July 8, 2024 05:02
Copy link
Contributor

@nepet nepet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack dd78a61

@YusukeShimizu YusukeShimizu merged commit c77a829 into master Jul 8, 2024
8 checks passed
@YusukeShimizu YusukeShimizu deleted the use-listpeerchannels branch July 8, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peerswap-listpeers missing channels field due to CLN API removal
3 participants