lwk: add backoff for send #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send sends a request using the lwkclient and handles retries in case of a "missing transaction" error. It uses an exponential backoff strategy for retries, with a maximum of 5 retries. This is a temporary workaround for an issue where a missing transaction error occurs even when the UTXO exists. If the issue persists, the backoff strategy may need adjustment. - Implement retry logic in the `send` function of `lwkclient` using an exponential backoff strategy to handle "missing transaction" errors. fixes: #325
|
Ok I think I've triggered the backoff for this swap attempt: Though in other canceled attempts I will get this error: |
|
Thank you for your investigation. The core issue lies in the failure to retrieve the result after broadcasting the transaction. In this situation, even though the transaction itself is valid on the network, the system cancels the swap, causing a problem where the balance decreases and cannot be recovered.
SolutionI will introduce backoff handling when retrieving transaction results. This can potentially mitigate errors caused by temporary failures or delays. ConsiderationsThe case where a swap is canceled even though an opening tx was broadcast may not only occur with LWK/electrs but could also happen with other backends. However, the probability is low. In the future, it may be necessary to implement a manual fund recovery command. For now, we will focus on stabilizing within the LWK environment and consider further actions if issues arise. Additional Information"failed to fund transaction: permanent error" occurs when there’s an error with LWK's send command but does not trigger backoff. Backoff only occurs when a "missing transaction" error is returned. |
GetRawTransaction retrieves the raw transaction data for a given transaction and handles retries in case of a "missing transaction" error. It uses an exponential backoff strategy for retries, with a maximum of 10 retries. This is a temporary workaround for an issue where a missing transaction error occurs even when the UTXO exists. If the issue persists, the backoff strategy may need adjustment. fixes: #325
|
Looks like this swap hit the "missing transaction" error, retried, and was able to eventually succeed: A different swap was canceled because the LWK backend was unreachable: Tested ACK 27077a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles retries in case of a "missing transaction" error.
It uses an exponential backoff strategy for retries, with a maximum of 5 retries.
fixes: #325