Remove renamed warn-by-default lints, v6 lint set #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`disallowed_type` and `disallowed_method` has been renamed to plural names in Rust 1.59 and also now are warn-by-default so we do not need to enable them anymore explicitly
MarijnS95
reviewed
Feb 25, 2022
| @@ -1,4 +1,4 @@ | |||
| // BEGIN - Embark standard lints v5 for Rust 1.55+ | |||
| // BEGIN - Embark standard lints v6 for Rust 1.55+ | |||
There was a problem hiding this comment.
Were they default-warn on v1.55 as well?
There was a problem hiding this comment.
no I don't think so, but I didn't want to say that this lint set technically requires 1.59 yet as it doesn't. and it is a bit of a stopgap release until we do v7 that does require 1.59 with new lints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disallowed_typeanddisallowed_methodhas been renamed to plural names in Rust 1.59 and also now are warn-by-default so we do not need to enable them anymore explicitlyPart of #59
Replaces #73