Add support for custom authority #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quettabit
force-pushed
the
add-custom-authority
branch
from
9aece41 to
ce64806
Compare
|
I'm fine with this, it's a breaking change but not too painful IMO. |
quettabit
force-pushed
the
add-custom-authority
branch
from
75d6303 to
38b0fa6
Compare
quettabit
force-pushed
the
add-custom-authority
branch
from
38b0fa6 to
aab510d
Compare
Jake-Shadle
approved these changes
Jun 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @Jake-Shadle ! i am in need of custom authority for fake gcs that is also mentioned in #21 , so just went with the quickest approach to add support for it. pls let me know WDYT