Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example config override for dummy app #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

utilityboy
Copy link
Contributor

Possibly closes #3 ?

If you're ok with this approach, I'll update the README as well.

@g-cassie
Copy link
Collaborator

@utilityboy The dummy app uses bootstrap right now so I think this will mess up all the formatting. The easiest thing is probably to put this exact example in the README and replace the current section on customizing style (which I think is actually wrong) with a guide.

@utilityboy
Copy link
Contributor Author

@g-cassie Sorry, I was suggesting to actually leave that code commented out for illustration purposes only. I'll fix.


export default FormMaster2000ConfigService.extend({

// default config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to flesh this out a bit so its crystal clear. Can you change to something like the following.

By default, form master uses the default classes for Bootstrap 3 style forms.  To
change this, extend the `fm-config` service and override the class names that you want.
For a list of the default classes see the base `fm-config` service in:

https://github.com/Emerson/ember-form-master-2000/blob/master/addon/services/fm-config.js

For example for semantic-ui style inputs you would include the following overrides:
formClass: 'ui form',
wrapperClass: 'field',
errorClass: 'error'

@g-cassie
Copy link
Collaborator

g-cassie commented Apr 16, 2016

Just made a comment on fleshing this out so its crystal clear - then I will merge. We can probably just copy and paste roughly the same thing into the README (replacing what is currently there) if you want to add that to the PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better documentation for initializers
2 participants