-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tests #1052
Upgrade tests #1052
Conversation
ENV PATH $PATH:/root/binaries | ||
|
||
# earthly +prep-genesis --CHAIN_ID=empowerchain-1 --STATE_SYNC_RPC=https://empower-rpc.polkachu.com:443 --STATE_SYNC_PEER=074640d8f2bc981fd201badd19c5b6dba38e00be@65.108.238.219:17456 | ||
prep-genesis: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions here:
- Do we have state sync set up ourselves (for both testnet and mainnet)?
- Should we make the args into a single arg (mainnet, testnet) and use a script or something to export args somehow? Got any good ideas how to make this a bit nicer to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Just enabled state sync on both.
- It'd go old fashioned way and create bash script(s) with the args and leave earthly invocation as it is
chain/Earthfile
Outdated
RUN sed -i -e 's/"voting_period": "172800s"/"voting_period": "30s"/g' ~/.empowerchain/config/genesis.json | ||
|
||
RUN empowerd start > /tmp/before_upgrade_log 2>&1 & sleep 10; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could of course be put into a script file, but not sure if there is much need for that? I am agnostic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably put it into a script file, because of all these escape characters :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
+ Coverage 60.40% 67.21% +6.80%
==========================================
Files 79 88 +9
Lines 7420 9040 +1620
==========================================
+ Hits 4482 6076 +1594
- Misses 2677 2703 +26
Partials 261 261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ENV PATH $PATH:/root/binaries | ||
|
||
# earthly +prep-genesis --CHAIN_ID=empowerchain-1 --STATE_SYNC_RPC=https://empower-rpc.polkachu.com:443 --STATE_SYNC_PEER=074640d8f2bc981fd201badd19c5b6dba38e00be@65.108.238.219:17456 | ||
prep-genesis: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Just enabled state sync on both.
- It'd go old fashioned way and create bash script(s) with the args and leave earthly invocation as it is
chain/Earthfile
Outdated
RUN sed -i -e 's/"voting_period": "172800s"/"voting_period": "30s"/g' ~/.empowerchain/config/genesis.json | ||
|
||
RUN empowerd start > /tmp/before_upgrade_log 2>&1 & sleep 10; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably put it into a script file, because of all these escape characters :)
Put stuff into scripts and cleaned up a bit. Should be more readable now. |
No description provided.