Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests #1052

Merged
merged 10 commits into from
Nov 9, 2023
Merged

Upgrade tests #1052

merged 10 commits into from
Nov 9, 2023

Conversation

gjermundgaraba
Copy link
Contributor

No description provided.

ENV PATH $PATH:/root/binaries

# earthly +prep-genesis --CHAIN_ID=empowerchain-1 --STATE_SYNC_RPC=https://empower-rpc.polkachu.com:443 --STATE_SYNC_PEER=074640d8f2bc981fd201badd19c5b6dba38e00be@65.108.238.219:17456
prep-genesis:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions here:

  1. Do we have state sync set up ourselves (for both testnet and mainnet)?
  2. Should we make the args into a single arg (mainnet, testnet) and use a script or something to export args somehow? Got any good ideas how to make this a bit nicer to use?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Just enabled state sync on both.
  2. It'd go old fashioned way and create bash script(s) with the args and leave earthly invocation as it is

chain/Earthfile Outdated
RUN sed -i -e 's/"voting_period": "172800s"/"voting_period": "30s"/g' ~/.empowerchain/config/genesis.json

RUN empowerd start > /tmp/before_upgrade_log 2>&1 & sleep 10; \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could of course be put into a script file, but not sure if there is much need for that? I am agnostic

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably put it into a script file, because of all these escape characters :)

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f01c11) 60.40% compared to head (c0174d6) 67.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
+ Coverage   60.40%   67.21%   +6.80%     
==========================================
  Files          79       88       +9     
  Lines        7420     9040    +1620     
==========================================
+ Hits         4482     6076    +1594     
- Misses       2677     2703      +26     
  Partials      261      261              
Flag Coverage Δ
chain 60.40% <ø> (ø)
cosmwasm 98.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ENV PATH $PATH:/root/binaries

# earthly +prep-genesis --CHAIN_ID=empowerchain-1 --STATE_SYNC_RPC=https://empower-rpc.polkachu.com:443 --STATE_SYNC_PEER=074640d8f2bc981fd201badd19c5b6dba38e00be@65.108.238.219:17456
prep-genesis:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Just enabled state sync on both.
  2. It'd go old fashioned way and create bash script(s) with the args and leave earthly invocation as it is

chain/Earthfile Outdated
RUN sed -i -e 's/"voting_period": "172800s"/"voting_period": "30s"/g' ~/.empowerchain/config/genesis.json

RUN empowerd start > /tmp/before_upgrade_log 2>&1 & sleep 10; \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably put it into a script file, because of all these escape characters :)

chain/Earthfile Outdated Show resolved Hide resolved
@gjermundgaraba gjermundgaraba requested a review from ba1ciu November 7, 2023 03:49
@gjermundgaraba
Copy link
Contributor Author

Put stuff into scripts and cleaned up a bit. Should be more readable now.
Take a quick look and if OK I will merge tomorrow and make final tests :)

@gjermundgaraba gjermundgaraba merged commit b8f519c into main Nov 9, 2023
16 checks passed
@gjermundgaraba gjermundgaraba deleted the upgrade-tests branch November 9, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants