Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SEO with auction pages #1074

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Fix SEO with auction pages #1074

merged 9 commits into from
Nov 27, 2023

Conversation

jschill
Copy link
Contributor

@jschill jschill commented Nov 27, 2023

To help crawlers to find our auction pages we need to replace click events with proper a-tags.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74df5f1) 60.39% compared to head (344f301) 67.21%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   60.39%   67.21%   +6.81%     
==========================================
  Files          79       88       +9     
  Lines        7419     9038    +1619     
==========================================
+ Hits         4481     6075    +1594     
- Misses       2677     2702      +25     
  Partials      261      261              
Flag Coverage Δ
chain 60.39% <ø> (ø)
cosmwasm 98.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ba1ciu ba1ciu merged commit 4d7b2ff into main Nov 27, 2023
14 checks passed
@ba1ciu ba1ciu deleted the seo-fix-view-auctions branch November 27, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants