Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download certificate #1139

Conversation

PiranavanShanmugavadivelu
Copy link
Contributor

@PiranavanShanmugavadivelu PiranavanShanmugavadivelu commented Jan 17, 2024

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d77758f) 98.95% compared to head (3a1a518) 72.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1139       +/-   ##
===========================================
- Coverage   98.95%   72.61%   -26.34%     
===========================================
  Files           9       88       +79     
  Lines        3351    10791     +7440     
===========================================
+ Hits         3316     7836     +4520     
- Misses         35     2692     +2657     
- Partials        0      263      +263     
Flag Coverage Δ
chain 60.75% <ø> (?)
cosmwasm 98.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ba1ciu ba1ciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to @jschill and @portlandnorway

…into 5965-remove-html-with-certificate-go-straight-to-pdf-generation
Copy link
Contributor

@jschill jschill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PiranavanShanmugavadivelu PiranavanShanmugavadivelu merged commit 91622b9 into main Jan 18, 2024
14 checks passed
@PiranavanShanmugavadivelu PiranavanShanmugavadivelu deleted the 5965-remove-html-with-certificate-go-straight-to-pdf-generation branch January 18, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants