lg_activity add new node to write the scene timestamps #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minshallj
reviewed
Jan 1, 2025
| def save_scene_played_time(data): | ||
| """Callback for /director/scene listener, updates the played time for the scene.""" | ||
| #input_file_path = '/media/videos/scene_times.json' | ||
| json_file_path = '/home/lg/scene_times.json' |
There was a problem hiding this comment.
this path could be a ros_param and might want to be in the /media directory like you have it above so it survives a reboot.
There was a problem hiding this comment.
the /media path is not writable on the docker so the video_manager.py reads this file in the docker and updates the scene_times.json file in the /media folder for now
minshallj
reviewed
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the node to keep updating a file with the scene timestamps inside the lg_activity package