Reference fixes for #189 #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like you've done a good bit of research on the new changes to Clojurescript, and how they affect instaparse. Can you summarize the problem for me, and what you did to fix it in this code? |
|
Hi Mark, I just found the commit that breaks the code and then followed what Mike Fikes suggested for specter here: redplanetlabs/specter#261. |
|
This seems to take care of the error, but not sure why.
|
|
Does that also resolve the performance issue you were seeing? |
|
The ended up being something else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not intended to be use as is, as it has more changes than the main issues.
I found the same clojurescript commit affecting specter: redplanetlabs/specter#261
Not sure what is the best fix for reader/read-string*.