Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp interface improvements #1789

Merged
merged 4 commits into from
Apr 2, 2024
Merged

cpp interface improvements #1789

merged 4 commits into from
Apr 2, 2024

Conversation

samuelpmish
Copy link
Collaborator

working on some fixes and improvements for the new cpp interface:

  • fixing inconsistent size_t vs std::size_t usage
  • use automatically generated ctors for enzyme::Active, enzyme::Const, ... , to support brace-initialization
  • add CTAD guides for C++17 and later (so users don't have to explicitly name the argument types)
  • added a new directory in tests for c++ interface examples and unit tests with CTest support (WIP)
  • disambiguate forward_by_reference implementation (see New C++ interface with lambda #1785)

I think @wsmoses also mentioned something about casting the function pointers to the appropriate types-- can you clarify what you want to happen and I'll add a test for it.

I'm also seeing an error in the return type deduction for Forward mode, so I'll look into that.

Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the sugar tests from fwd and reverse mode integration folders here too?

@wsmoses wsmoses merged commit 57d07ed into main Apr 2, 2024
24 of 46 checks passed
@wsmoses wsmoses deleted the cpp_interface_improvements branch April 2, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants