Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding rust ADBench version #1797

Open
wants to merge 90 commits into
base: main
Choose a base branch
from
Open

adding rust ADBench version #1797

wants to merge 90 commits into from

Commits on May 27, 2024

  1. adding gmm

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    9770ceb View commit details
    Browse the repository at this point in the history

  2. working C too

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    9f05ff8 View commit details
    Browse the repository at this point in the history

  3. Delete enzyme/benchmarks/ReverseMode/gmmrs/src/main.rs2

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4da9910 View commit details
    Browse the repository at this point in the history

  4. rust setup

    @wsmoses
    wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0f68ce8 View commit details
    Browse the repository at this point in the history

  5. add files

    @wsmoses
    wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    7995eb3 View commit details
    Browse the repository at this point in the history

  6. improve makefile and fix c ffi

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    069e3cb View commit details
    Browse the repository at this point in the history

  7. maybe needed? pthread for cmake

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    be54358 View commit details
    Browse the repository at this point in the history

  8. bench gmm: use path relative to Makefile

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4423222 View commit details
    Browse the repository at this point in the history

  9. Fix byref issue for rust abi

    @wsmoses
    wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    7b5a24c View commit details
    Browse the repository at this point in the history

  10. Add primal bench/test

    @wsmoses
    wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ea03750 View commit details
    Browse the repository at this point in the history

  11. fix math

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    77a130f View commit details
    Browse the repository at this point in the history

  12. write into return var

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4abf2bf View commit details
    Browse the repository at this point in the history

  13. Cleanup gmm config

    @wsmoses
    wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5cde3d7 View commit details
    Browse the repository at this point in the history

  14. bench gmm: make cmath::lgamma with libm as an optional feature

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    af6583d View commit details
    Browse the repository at this point in the history

  15. oxidize - more noalias

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    48c2e1f View commit details
    Browse the repository at this point in the history

  16. reduce caching

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ba75484 View commit details
    Browse the repository at this point in the history

  17. bench gmm: makefile dep on Cargo.toml, split targets

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    9394028 View commit details
    Browse the repository at this point in the history

  18. revert cmake pthread since only needed for Rust

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    814eb62 View commit details
    Browse the repository at this point in the history

  19. bench gmm: fix primal (sqnorm length matters)

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    41157fa View commit details
    Browse the repository at this point in the history

  20. bench gmm: quash rust warnings

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    114f236 View commit details
    Browse the repository at this point in the history

  21. adding ba benchmark

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    012cf4c View commit details
    Browse the repository at this point in the history

  22. Benchmark ba

    @wsmoses
    wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0430e44 View commit details
    Browse the repository at this point in the history

  23. fix ba primal

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    4b0062b View commit details
    Browse the repository at this point in the history

  24. adding unsafe gmm version

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    1f27479 View commit details
    Browse the repository at this point in the history

  25. Add FFT and LSTM benchmark for Rust Enzyme

    @bytesnake @wsmoses
    bytesnake authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    af3e078 View commit details
    Browse the repository at this point in the history

  26. adding unsafe Rust fft version (how to run?)

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c8bcfe9 View commit details
    Browse the repository at this point in the history

  27. imprv safe rus tto work like c++

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    cad4221 View commit details
    Browse the repository at this point in the history

  28. unsafe version not crashing

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    f0bf16b View commit details
    Browse the repository at this point in the history

  29. fix lstm makefile

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    12e9a4a View commit details
    Browse the repository at this point in the history

  30. adding unsafe rust lstm version

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    688721d View commit details
    Browse the repository at this point in the history

  31. run full fft tests

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    7ca8092 View commit details
    Browse the repository at this point in the history

  32. Delete enzyme/benchmarks/ReverseMode/lstm/src/main.rs

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    73f8075 View commit details
    Browse the repository at this point in the history

  33. cleanup and correctness

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    ba3aa5d View commit details
    Browse the repository at this point in the history

  34. initial (compiling) rust ode version

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    2737734 View commit details
    Browse the repository at this point in the history

  35. cleanups

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    1ffbaaa View commit details
    Browse the repository at this point in the history

  36. fix ba bench

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8bd316a View commit details
    Browse the repository at this point in the history

  37. bench gmm: move allocation of scratch space outside AD'd function

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c769dac View commit details
    Browse the repository at this point in the history

  38. bench gmm: switch scratch from Const to Duplicated 

    This makes the reverse mode correct, and a bit faster than the old
version (with allocations inside the AD'd code).
    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    c5e1f19 View commit details
    Browse the repository at this point in the history

  39. bench gmm: match C++ performance by asserting sizes of work slices

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    947852c View commit details
    Browse the repository at this point in the history

  40. bench gmm: shed unused import (warning)

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    cb9d403 View commit details
    Browse the repository at this point in the history

  41. bench lstm: optimize using length assertions

    @jedbrown @wsmoses
    jedbrown authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    dbffef6 View commit details
    Browse the repository at this point in the history

  42. adding unsafe ba version

    @ZuseZ4 @wsmoses
    ZuseZ4 authored and wsmoses committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0174227 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. smaller perf improvements

    @ZuseZ4
    ZuseZ4 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    629f87c View commit details
    Browse the repository at this point in the history

  2. small improvment

    @ZuseZ4
    ZuseZ4 committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    c6f44b3 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. clean up ode-real example (not building)

    @ZuseZ4
    ZuseZ4 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fb6df5b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. add ba.cpp version without restrict

    @ZuseZ4
    ZuseZ4 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    a6d4a7c View commit details
    Browse the repository at this point in the history

  2. add gmm version without restrict

    @ZuseZ4
    ZuseZ4 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    d08142b View commit details
    Browse the repository at this point in the history

  3. add lstm version without restrict

    @ZuseZ4
    ZuseZ4 committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    d6b35b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Revert "smaller perf improvements" 

    This reverts commit 629f87c.
    @ZuseZ4
    ZuseZ4 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    55a76b9 View commit details
    Browse the repository at this point in the history

  2. adding lstm primal cxx overhead benchmark

    @ZuseZ4
    ZuseZ4 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    de87081 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'main' into rust-bench

    @ZuseZ4
    ZuseZ4 authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5d9b026 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. fix ode-real example, correct results, faster than c++, without dupno… 

    …need
    @ZuseZ4
    ZuseZ4 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7d70dc5 View commit details
    Browse the repository at this point in the history

  2. remove boost leftovers

    @ZuseZ4
    ZuseZ4 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fdb0d09 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. fix makefiles to use new rustflags

    @ZuseZ4
    ZuseZ4 committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    747e4f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. add tanh support for llvm19+

    @ZuseZ4
    ZuseZ4 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    05d3e87 View commit details
    Browse the repository at this point in the history

  2. fix safe fft performance

    @ZuseZ4
    ZuseZ4 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1fe64c0 View commit details
    Browse the repository at this point in the history

  3. fix (mostly) safe lstm perf

    @ZuseZ4
    ZuseZ4 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    7f26f43 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. make lstm benchmark fair by running c++ with O3

    @ZuseZ4
    ZuseZ4 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    7ecd27b View commit details
    Browse the repository at this point in the history

  2. make ba bench fair by running c++ with O3

    @ZuseZ4
    ZuseZ4 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    aaef8b3 View commit details
    Browse the repository at this point in the history

  3. make ode-real/bruss fair by adjusting both

    @ZuseZ4
    ZuseZ4 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    51ef17a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. equalize benchmark configs and move over to new use std::autodiff::au… 

    …todiff
    @ZuseZ4
    ZuseZ4 committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    9c9f276 View commit details
    Browse the repository at this point in the history

  2. move Rust to DuplicatedOnly

    @ZuseZ4
    ZuseZ4 committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    5ebcd1e View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. cleanup makefiles

    @ZuseZ4
    ZuseZ4 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    aeed32d View commit details
    Browse the repository at this point in the history

  2. update fft-tapenade to be correct but segfault

    @ZuseZ4
    ZuseZ4 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1542a38 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. add mayalias/unsafe ode-real/BRUSS benchmark versions

    @ZuseZ4
    ZuseZ4 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    047f121 View commit details
    Browse the repository at this point in the history

  2. fix safe fft performance

    @ZuseZ4
    ZuseZ4 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3d25858 View commit details
    Browse the repository at this point in the history

  3. cleanup fft

    @ZuseZ4
    ZuseZ4 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2d04892 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. bench fft: more idiomatic safe Rust

    @jedbrown
    jedbrown committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a273bdf View commit details
    Browse the repository at this point in the history

  2. bench fft: use size_t in C++ for parity with Rust usize

    @jedbrown
    jedbrown committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    65e1eaf View commit details
    Browse the repository at this point in the history

  3. bench fft: move from i+=2 to ii++ in loop increments

    @jedbrown
    jedbrown committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    609bf4d View commit details
    Browse the repository at this point in the history

  4. move rust fft to use i32 for isign

    @ZuseZ4
    ZuseZ4 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b722c87 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. safe rust fft without bounds checking

    @ZuseZ4
    ZuseZ4 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a7943f0 View commit details
    Browse the repository at this point in the history

  2. Add -fno-math-errno to each makefile for fairness

    @ZuseZ4
    ZuseZ4 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    59f866b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into rust-bench 

    * main: (49 commits)
  Fix iv of constant (#2141)
  Update benchmarks (#2035)
  Implement tgamma derivative (#2140)
  tgamma error improvement (#2139)
  Improve cache index error message (#2138)
  Fixes warnings and adds missing header guards (#2124)
  mlir: cache and reuse reverse funcs (#2133)
  mlir: implement forward mode for func.call (#2134)
  mlir: Func call reverse diff (#2127)
  Update build_tarballs.jl
  Fix combined temp cache for reverse (#2131)
  Improve runtime activity err message (#2132)
  Fix undef value storage (#2129)
  Adapt to const tblgen (#2128)
  Add gcloaded TT (#2125)
  Fix blas decl updater indexing (#2123)
  Add header files to ClangEnzyme target (#2062)
  Improve unknown function error messages (#2120)
  Fix handle sync (#2122)
  Support more Julia 1.11 functions (#2121)
  ...
    @jedbrown
    jedbrown committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    119c2ac View commit details
    Browse the repository at this point in the history

  4. bench fft: __builtin_sin not necessary with -fno-math-errno

    @jedbrown
    jedbrown committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6460848 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. move c++ lstm to also use size_t, since Rust uses usize

    @ZuseZ4
    ZuseZ4 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3b174ea View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. adjust gmm, but breaks tapenade

    @ZuseZ4
    ZuseZ4 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8945897 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Revert "move c++ lstm to also use size_t, since Rust uses usize" 

    This reverts commit 3b174ea.
    @ZuseZ4
    ZuseZ4 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    a73a1ad View commit details
    Browse the repository at this point in the history

  2. fix single gmm size for benchmarking

    @ZuseZ4
    ZuseZ4 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    dca82bb View commit details
    Browse the repository at this point in the history

  3. safe lstm without alias info

    @ZuseZ4
    ZuseZ4 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    f7c75a2 View commit details
    Browse the repository at this point in the history

  4. use new flag to keep const ptr/ref while still not emitting noalias

    @ZuseZ4
    ZuseZ4 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    06b135f View commit details
    Browse the repository at this point in the history

  5. make safe fft safe again

    @ZuseZ4
    ZuseZ4 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    74a3784 View commit details
    Browse the repository at this point in the history

  6. bench fft: cleaner to use step_by(2)

    @jedbrown
    jedbrown committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    ba7cf82 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. bench gmm: fix Tapenade

    @jedbrown
    jedbrown committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d5bd596 View commit details
    Browse the repository at this point in the history

  2. bench gmm: fix C++ primal (negative size_t)

    @jedbrown
    jedbrown committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4d78820 View commit details
    Browse the repository at this point in the history

  3. bench fft: avoid bounds checks in safe Rust 

    This yields identical assembly apart from asserts at the top of safe::radix2.
    @jedbrown
    jedbrown committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    13ef016 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. update fft to make benchmarking more reliable, make safe rust version… 

    … fully safe
    @ZuseZ4
    ZuseZ4 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9f67bd1 View commit details
    Browse the repository at this point in the history

  2. improve lstm output, makefiles

    @ZuseZ4
    ZuseZ4 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    88feab6 View commit details
    Browse the repository at this point in the history

  3. bench fft: closer C++ code to Rust and use -fno-plt 

    Note that -mtune=cascadelake is only about tuning (like instruction
timing) not arch/features.
    @jedbrown
    jedbrown committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    31fd712 View commit details
    Browse the repository at this point in the history

  4. more numactl

    @ZuseZ4
    ZuseZ4 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    abf2a26 View commit details
    Browse the repository at this point in the history