[ts][pixi-v8] Removed useless warning about update invocation with au…

…toUpdate.
EsotericSoftware · Nov 13, 2024 · 814f0ae · 814f0ae
1 parent fb3855a
commit 814f0ae
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 17 deletions.
diff --git a/spine-ts/spine-pixi-v8/src/Spine.ts b/spine-ts/spine-pixi-v8/src/Spine.ts
@@ -213,7 +213,6 @@ export class Spine extends ViewContainer {
 		this._debug = value;
 	}
 
-	private autoUpdateWarned = false;
 	private _autoUpdate = true;
 
 	public get autoUpdate (): boolean {
@@ -223,9 +222,7 @@ export class Spine extends ViewContainer {
 	public set autoUpdate (value: boolean) {
 		if (value) {
 			Ticker.shared.add(this.internalUpdate, this);
-			this.autoUpdateWarned = false;
-		}
-		else {
+		} else {
 			Ticker.shared.remove(this.internalUpdate, this);
 		}
 
@@ -262,11 +259,6 @@ export class Spine extends ViewContainer {
 
 	/** If {@link Spine.autoUpdate} is `false`, this method allows to update the AnimationState and the Skeleton with the given delta. */
 	public update (dt: number): void {
-		if (this.autoUpdate && !this.autoUpdateWarned) {
-			console.warn('You are calling update on a Spine instance that has autoUpdate set to true. This is probably not what you want.');
-			this.autoUpdateWarned = true;
-		}
-
 		this.internalUpdate(0, dt);
 	}
 

diff --git a/spine-ts/spine-pixi-v8/src/SpinePipe.ts b/spine-ts/spine-pixi-v8/src/SpinePipe.ts
@@ -40,7 +40,7 @@ import { BatchableSpineSlot } from './BatchableSpineSlot';
 import { Spine } from './Spine';
 import { MeshAttachment, RegionAttachment } from '@esotericsoftware/spine-core';
 
-const spineBlendModeMap : Record<number, BLEND_MODES> = {
+const spineBlendModeMap: Record<number, BLEND_MODES> = {
 	0: 'normal',
 	1: 'add',
 	2: 'multiply',
@@ -183,15 +183,15 @@ export class SpinePipe implements RenderPipe<Spine> {
 		this.renderer = null as any;
 	}
 
-	private _getSpineData(spine: Spine): GpuSpineDataElement {
+	private _getSpineData (spine: Spine): GpuSpineDataElement {
 		return this.gpuSpineData[spine.uid] || this._initMeshData(spine);
-    }
+	}
 
-	private _initMeshData(spine: Spine): GpuSpineDataElement {
-        this.gpuSpineData[spine.uid] = { slotBatches: { } };
-        spine.on('destroyed', this._destroyRenderableBound);
-        return this.gpuSpineData[spine.uid];
-    }
+	private _initMeshData (spine: Spine): GpuSpineDataElement {
+		this.gpuSpineData[spine.uid] = { slotBatches: {} };
+		spine.on('destroyed', this._destroyRenderableBound);
+		return this.gpuSpineData[spine.uid];
+	}
 }
 
 extensions.add(SpinePipe);