Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some usability improvements, and fix some compiler warnings #172

Open
wants to merge 109 commits into
base: master
Choose a base branch
from
Open

Some usability improvements, and fix some compiler warnings #172

wants to merge 109 commits into from

Commits on Apr 20, 2021

  1. Don't strip all optimization flags. 

    Some basic compiler functionality is dependendent on having
optimizations enabled.

There shouldn't be any issues with -O2, which is the default for qmake's
release builds.
    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    b9335d0 View commit details
    Browse the repository at this point in the history

  2. add standard shortcut for quit action

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    6b1e3b6 View commit details
    Browse the repository at this point in the history

  3. don't crash when failing to load the default list of waveforms

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    19e0fed View commit details
    Browse the repository at this point in the history

  4. add some missing keyboard accelerators

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    51bf7de View commit details
    Browse the repository at this point in the history

  5. fix warning of using uninitialized variable

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2805c5e View commit details
    Browse the repository at this point in the history

  6. feedback when failing to flash/fix warning about unused stored value

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    5b73248 View commit details
    Browse the repository at this point in the history

  7. fix clang warning about using int as bool

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    7293fb4 View commit details
    Browse the repository at this point in the history

  8. fix uninitialized value (and remove some magic 'auto' variable)

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d1e50af View commit details
    Browse the repository at this point in the history

  9. fix some minor warnings

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    7bbf5d1 View commit details
    Browse the repository at this point in the history

  10. add dialog with pinout for easy access

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    14b3b39 View commit details
    Browse the repository at this point in the history

  11. fix some type issues

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    29a76c0 View commit details
    Browse the repository at this point in the history

  12. fix warning about unhandled enum values

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    140873a View commit details
    Browse the repository at this point in the history

  13. don't emit code in all translation units, fix warning

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    a9d04cb View commit details
    Browse the repository at this point in the history

  14. let clang-tidy clean up the int/bool issues

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    5960743 View commit details
    Browse the repository at this point in the history

  15. fix use of uninitialized memory

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    319adfa View commit details
    Browse the repository at this point in the history

  16. fix unused warning

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2c04611 View commit details
    Browse the repository at this point in the history

  17. fix invalid format specifier

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    5772bd1 View commit details
    Browse the repository at this point in the history

  18. fix potential memory leak

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3b29bfe View commit details
    Browse the repository at this point in the history

  19. fix potential division by zero

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    91ecafd View commit details
    Browse the repository at this point in the history

  20. let clang-tidy do some minor performance improvements

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    1064ac4 View commit details
    Browse the repository at this point in the history

  21. final invalid type specifier, I think

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3e1dba0 View commit details
    Browse the repository at this point in the history

  22. bundle default waveforms in the application binary

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    b75cb30 View commit details
    Browse the repository at this point in the history

  23. port away from dangerous strcpy

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    cc041c3 View commit details
    Browse the repository at this point in the history

  24. simplify the waveform reading and make it a bit more robust

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    e661413 View commit details
    Browse the repository at this point in the history

  25. fix minor compiler warnings

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c97a2cc View commit details
    Browse the repository at this point in the history

  26. port away from some deprecated APIs

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d37e184 View commit details
    Browse the repository at this point in the history

  27. fix using up/down keys in the spinboxes

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    6f9b062 View commit details
    Browse the repository at this point in the history

  28. port away from deprecated APIs, stop leaking memory

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3c20332 View commit details
    Browse the repository at this point in the history

  29. add button to automatically set ranges for what is on the screen

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    39f0c9f View commit details
    Browse the repository at this point in the history

  30. mis-groked the code

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    a66ad5f View commit details
    Browse the repository at this point in the history

  31. remove some dead code

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    403a989 View commit details
    Browse the repository at this point in the history

  32. minor issues

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d4dc2ee View commit details
    Browse the repository at this point in the history

  33. replace magic numbers with enum

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    526fdfb View commit details
    Browse the repository at this point in the history

  34. fix some direct memory leak (should ideally be rewritten away from ra… 

    …w memory buffers)
    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f0f5fc8 View commit details
    Browse the repository at this point in the history

  35. fix remaining memory leaks, mostly by letting Qt handle it

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    4597487 View commit details
    Browse the repository at this point in the history

  36. fix slot signature

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    23b0b21 View commit details
    Browse the repository at this point in the history

  37. remove some dead code, fixes warnings

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    654a2f5 View commit details
    Browse the repository at this point in the history

  38. fix another couple of warnings from Qt about unused slots

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d987273 View commit details
    Browse the repository at this point in the history

  39. don't use raw pointers, fixes a race condition crash at exit

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    92453ad View commit details
    Browse the repository at this point in the history

  40. fix hanging on exit

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    4eaeffc View commit details
    Browse the repository at this point in the history

  41. don't busyloop

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    9a5e133 View commit details
    Browse the repository at this point in the history

  42. fix deprecated warnings in bundled version of qcustomplot

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    facfe3d View commit details
    Browse the repository at this point in the history

  43. fix potential double free (really should port away from raw C buffers)

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    ad64f1f View commit details
    Browse the repository at this point in the history

  44. fix libusb shutdown

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    9fb61b5 View commit details
    Browse the repository at this point in the history

  45. port to C++ smart pointers, avoids raw memory juggling and associated… 

    … mess
    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2cd9f51 View commit details
    Browse the repository at this point in the history

  46. fix build with qcustomplot2

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    aefa583 View commit details
    Browse the repository at this point in the history

  47. allow building with system version of qcustomplot

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    446a1ca View commit details
    Browse the repository at this point in the history

  48. fix missing emits

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    2594618 View commit details
    Browse the repository at this point in the history

  49. fix unused

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    7460151 View commit details
    Browse the repository at this point in the history

  50. fix signedness

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    b3a8722 View commit details
    Browse the repository at this point in the history

  51. implement baudot decoding

    @sandsmark
    sandsmark committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    81570aa View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. fix some crashing

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    e99f003 View commit details
    Browse the repository at this point in the history

  2. port away from deprecated libusb API

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    ec4c5e9 View commit details
    Browse the repository at this point in the history

  3. more usage of enums and flags to make code understandable

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    3f5604b View commit details
    Browse the repository at this point in the history

  4. fix memory leak

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    35bed4c View commit details
    Browse the repository at this point in the history

  5. clean up manual firmware recovery UI code a bit

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    f394ccd View commit details
    Browse the repository at this point in the history

  6. try to fix some issues with broken zooming

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    551c450 View commit details
    Browse the repository at this point in the history

  7. .... old style signals and slots

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    ae6fb8e View commit details
    Browse the repository at this point in the history

  8. more porting away from boolean traps

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    70c9707 View commit details
    Browse the repository at this point in the history

  9. fix some minor warnings

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    f0205ea View commit details
    Browse the repository at this point in the history

  10. some memory safety

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    c6fbd05 View commit details
    Browse the repository at this point in the history

  11. fix more magic numbers

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    0c78851 View commit details
    Browse the repository at this point in the history

  12. move DisplayControl class to separate files

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    6e9f461 View commit details
    Browse the repository at this point in the history

  13. move zooming code out into separate functions

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    8c1d355 View commit details
    Browse the repository at this point in the history

  14. fix whitespace, in separate commit for better history

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    6e5894e View commit details
    Browse the repository at this point in the history

  15. more protection against division by zero

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    8ff4c86 View commit details
    Browse the repository at this point in the history

  16. avoid including QWheelEvent in displaycontrol

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    ed40bd7 View commit details
    Browse the repository at this point in the history

  17. better naming

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    d529080 View commit details
    Browse the repository at this point in the history

  18. goddamn pixel/angle delta

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    760f67b View commit details
    Browse the repository at this point in the history

  19. goddamn qt and stupid deprecations

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    a400004 View commit details
    Browse the repository at this point in the history

  20. add some missing emits

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    5866223 View commit details
    Browse the repository at this point in the history

  21. fix some connections

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    502c733 View commit details
    Browse the repository at this point in the history

  22. last of the connects (except the android code)

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    d76ee6b View commit details
    Browse the repository at this point in the history

  23. fix cursor text with QCP 2

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    685bfec View commit details
    Browse the repository at this point in the history

  24. fix build with system version of QCP

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    cb86884 View commit details
    Browse the repository at this point in the history

  25. start porting stuff away from shitty STL APIs so it is possible to debug

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    3f5f8a9 View commit details
    Browse the repository at this point in the history

  26. clang-tidy

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    8cc496e View commit details
    Browse the repository at this point in the history

  27. fix spin boxes not updating

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    1062db6 View commit details
    Browse the repository at this point in the history

  28. clean up the shortcuts

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    e04b5c5 View commit details
    Browse the repository at this point in the history

  29. fix division by zero

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    bc51416 View commit details
    Browse the repository at this point in the history

  30. proper default window size

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    e119cfe View commit details
    Browse the repository at this point in the history

  31. add shortcut to zoom back out again

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    35aa228 View commit details
    Browse the repository at this point in the history

  32. I never which color is which

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    06c23f6 View commit details
    Browse the repository at this point in the history

  33. try to improve the plotting

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    1c211a5 View commit details
    Browse the repository at this point in the history

  34. need a better downsampling

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    3c063f6 View commit details
    Browse the repository at this point in the history

  35. minor fixes

    @sandsmark
    sandsmark committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    cfe2634 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. fix building with old libusb versions

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    4b4cd0d View commit details
    Browse the repository at this point in the history

  2. fix assert on exit in libusb

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    8b01c52 View commit details
    Browse the repository at this point in the history

  3. tradeoff a tiny bit of performance (5-10% on a 1.9GHz core)

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    ad417bc View commit details
    Browse the repository at this point in the history

  4. better default

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    7d72b92 View commit details
    Browse the repository at this point in the history

  5. memory safety

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    128a93c View commit details
    Browse the repository at this point in the history

  6. don't use zero for pointers

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    1fa80e5 View commit details
    Browse the repository at this point in the history

  7. fix the key event override when hovering the scope

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    7fdae93 View commit details
    Browse the repository at this point in the history

  8. don't hardcode default values everywhere

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    98bbf81 View commit details
    Browse the repository at this point in the history

  9. use just a single CONFIG option

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    b909385 View commit details
    Browse the repository at this point in the history

  10. I think I finally found a usable method of downsampling with an OK tr… 

    …adeoff between performance and representative display result
    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    562613d View commit details
    Browse the repository at this point in the history

  11. expose selecting downsampling method in the UI

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    a45b82c View commit details
    Browse the repository at this point in the history

  12. whoops, should be in sync with UI

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    1132f81 View commit details
    Browse the repository at this point in the history

  13. I'm not a smart person

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    c1c9eca View commit details
    Browse the repository at this point in the history

  14. trigger works a bit more

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    1d0e282 View commit details
    Browse the repository at this point in the history

  15. tiny performance improvement for trigger

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    0bb3bbc View commit details
    Browse the repository at this point in the history

  16. fix trigger randomly not working with auto gain/changing gain

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    0e20265 View commit details
    Browse the repository at this point in the history

  17. the lack of emit markings was really confusing

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    079e081 View commit details
    Browse the repository at this point in the history

  18. use nullptr

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    f5219d0 View commit details
    Browse the repository at this point in the history

  19. remove redundant void arguments

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    c80f110 View commit details
    Browse the repository at this point in the history

  20. fix some minor clang warnings

    @sandsmark
    sandsmark committed May 9, 2021
    Configuration menu
    Copy the full SHA
    867ffab View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. add some translucency to the plots, makes it a bit easier to see over… 

    …lapping
    @sandsmark
    sandsmark committed May 26, 2021
    Configuration menu
    Copy the full SHA
    0ac0323 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. accelerator

    @sandsmark
    sandsmark committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    3af25e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2021

  1. some cleanup

    @sandsmark
    sandsmark committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    536da41 View commit details
    Browse the repository at this point in the history