Change StatusCode
to handle unknown status codes
#230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
This PR:
Tide's design of their status code type (which we copied) as an enum, is not resilient against new status codes or status codes unknown to the server framework (such as ELB-specific status codes). This caused a panic in a Cappuccino node when it received a response with a status code it did not recognize.
This changes
StatusCode
from an enum to a wrapper aroundreqwest::StatusCode
, which is itself a wrapper around au16
. As such, it can represent any status code in the allowed range without necessarily knowing what a certain status represents.We keep most of the same interface by reimplementing all the appropriate and conversion traits. However, there are a couple of breaking changes:
From<StatusCode> for tide::StatusCode
; instead we implementTryFrom
, so we can return an error instead of panicking if it is a status code thattide
cannot handlereqwest
does