Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatisticalQueryGroupAndSort fixes #1514

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

williambohrmann3
Copy link
Collaborator

@williambohrmann3 williambohrmann3 commented Aug 20, 2024

Description

  • Fixes app crashes by using List instead of an ObservableCollection
  • Cleans up UI
  • Replaces ListViews with CollectionViews
  • Adds full stops to comments
  • Follows established C# coding conventions (for example, use of var)
  • Fixes results screen (cannot scroll nor close results)
  • Remove unused ShortName class member

Screenshots (before then after)

Config query

before
after

Results

before
after

Type of change

  • Bug fix

Platforms tested on

  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files
  • Screenshots are correct size and display in description tab (800 x 600 on Windows, MAUI mobile platforms use the MAUI Windows screenshot)

fixes app crashes by using List not ObservableCollection, cleans up UI, replaces ListViews with CollectionViews, adds full stops to comments
Copy link
Collaborator

@duffh duffh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@williambohrmann3 williambohrmann3 merged commit 3105668 into main Aug 26, 2024
6 checks passed
@williambohrmann3 williambohrmann3 deleted the wbohr/StatsQueryGroupAndSort branch August 26, 2024 20:32
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants