-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the sample for the 3d tiles layer #1662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I'm really impressed, this is really well done! There's a few finicky changes, plus some code cleanup that needs to be done, but on the whole you should be really proud of this!
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.h
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/README.metadata.json
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random code cleanup. Try to avoid double line breaks and generally the first line in a method should not be a line break.
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
What's the status of this PR? Is it being redesigned to use services and remove the PE Data, since 200.4 will automatically use the required grid files? |
@ldanzinger I created this PR but was unable to merge it because the dataset I used had not been finalized. Ping has logged an issue for this in our backlog. @khajra can probably shed more light on this. |
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/README.metadata.json
Outdated
Show resolved
Hide resolved
@tanneryould, I just updated this PR to reflect the change on the sample design. Please do another round of review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to remove a few things
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.h
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.h
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
Thanks for spotting these redundancies. I got them removed. |
ArcGISRuntimeSDKQt_CppSamples/Scenes/Add3DTilesLayer/Add3DTilesLayer.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
Description
Add a new cpp sample for the 3d tiles layer.
Type of change
Platforms tested on:
Checklist