AR: World scale #466
Closed
AR: World scale #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
des12437
reviewed
Oct 10, 2023
| @MainActor | ||
| private func updateSceneView(for location: Location) { | ||
| // Make sure there is at least a minimum horizontal and vertical accuracy. | ||
| guard location.horizontalAccuracy < 10 && location.verticalAccuracy < 10 else { return } |
There was a problem hiding this comment.
The scene content is not rendering since my horizontal accuracy is 35 meters and vertical accuracy is ~16 meters outdoors. Are these values too low or is there a way to calibrate the device compass?
There was a problem hiding this comment.
It would be unrelated to the compass, it's the GPS receiver. You can try again in a little while and see if some satellites come into view.
Co-authored-by: Destiny Hochhalter <[email protected]>
Co-authored-by: Destiny Hochhalter <[email protected]>
Co-authored-by: Destiny Hochhalter <[email protected]>
rolson
requested review from
des12437
and removed request for
pgruenler and
des12437
|
Before merging this needs to be tested with the same data we tested 100.x with. |
Merge v.next into main for 200.3
dfeinzimer
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Just a couple of suggestions for the preambles since we cleaned them up everywhere else (see #537).
Co-authored-by: David Feinzimer <[email protected]>
Update world scale AR
|
Closing in favor of #556. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements world scale AR with GPS coordinates.