Offline: Open a preplanned map area #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
reviewed
Aug 21, 2024
Sources/ArcGISToolkit/Components/Offline/OfflineMapAreasView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
Aug 21, 2024
Sources/ArcGISToolkit/Components/Offline/PreplannedMapModel.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/OfflineMapAreasView.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Remember, when writing code, start by limiting the exposure as much as possible. If it can be private, keep it private. If not, see if it can be just file private. If not, see it if can be just internal, etc. It is easy to increase the exposure of something later on down the road. It is much harder to reduce the exposure of something.
Sources/ArcGISToolkit/Components/Offline/OfflineMapAreasView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/OfflineMapAreasView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/OfflineMapAreasView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/OfflineMapAreasView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedMapModel.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
Aug 22, 2024
Sources/ArcGISToolkit/Components/Offline/OfflineMapAreasView.swift
Outdated
Show resolved
Hide resolved
OfflineMapAreasExample/OfflineMapAreasExample/OfflineMapAreasExampleView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/OfflineMapAreasView.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
philium
reviewed
Aug 22, 2024
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
rolson
reviewed
Aug 23, 2024
Sources/ArcGISToolkit/Components/Offline/PreplannedListItemView.swift
Outdated
Show resolved
Hide resolved
|
This PR is ready for re-review. |
yo1995
approved these changes
Aug 26, 2024
yo1995
approved these changes
Aug 26, 2024
|
@philium can you please re-review this PR when you have a chance? Thank you! |
philium
approved these changes
Aug 27, 2024
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
swift/5358Adds support to open a downloaded preplanned map area with the "open" button which dismisses the view and returns a
Mapvia theonMapSelectionChangedview modifier. If the preplanned map area's mobile map package fails to load when opened then the view's status is set tommpkLoadFailure.