Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow-item): fix TS error caused by FlowItemLike type #10802

Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 20, 2024

Related Issue: #10801

Summary

Restores internal prop that was unintentionally made private by #10482.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Nov 20, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 20, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

though need to double check if your docs rendering excludes @internal properties.

In docs.json it will appear like this:

          "docsTags": [
            {
              "name": "internal"
            }
          ],

@jcfranco
Copy link
Member Author

though need to double check if your docs rendering excludes @internal properties.

I believe the doc site ignores @private and @ignore, but not @internal. @macandcheese I'll submit a PR for this.

@jcfranco jcfranco merged commit 22c46c7 into dev Nov 20, 2024
15 of 16 checks passed
@jcfranco jcfranco deleted the jcfranco/10801-mark-flow-item-showBackButton-as-internal branch November 20, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants