Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): fix item key functionality #11191

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

driskull
Copy link
Member

@driskull driskull commented Jan 2, 2025

Related Issue: #11154

Summary

Only honor navigation key functionality when items are present

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

Only honor navigation key functionality when items are present
@driskull driskull added skip visual snapshots Pull requests that do not need visual regression testing. no changelog entry Use the commit override to avoid a changelog entry labels Jan 2, 2025
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 2, 2025
@driskull driskull marked this pull request as ready for review January 2, 2025 21:28
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Before merging, can you add/update a test to cover this?

@jcfranco jcfranco added no changelog entry Use the commit override to avoid a changelog entry and removed no changelog entry Use the commit override to avoid a changelog entry labels Jan 2, 2025
@driskull driskull merged commit d2ced69 into dev Jan 2, 2025
10 checks passed
@driskull driskull deleted the dris0000/autocomplete-key-fix branch January 2, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants