Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(themed): disable animations for consistent assertion results #11201

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 4, 2025

Related Issue: N/A

Summary

This helps avoid test failures caused by animations/transitions.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 4, 2025
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 4, 2025
Copy link
Contributor

@Elijbet Elijbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jcfranco jcfranco merged commit b6034be into dev Jan 4, 2025
17 of 18 checks passed
@jcfranco jcfranco deleted the jcfranco/ensure-theming-tests-have-no-transitions branch January 4, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants