Added /sell multipliers with configuration #4770
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature request @ EssentialsX#3934
pop4959
added
type: enhancement
JRoy
requested changes
Sep 3, 2023
| @@ -405,6 +405,7 @@ public interface ISettings extends IConf { | |||
| boolean isUpdateCheckEnabled(); | |||
|
|
|||
| boolean showZeroBaltop(); | |||
| BigDecimal getMultiplier(final User user); | |||
There was a problem hiding this comment.
Suggested change
| BigDecimal getMultiplier(final User user); | |
| BigDecimal getMultiplier(final User user); |
| @@ -91,7 +91,7 @@ public void run(final Server server, final User user, final String commandLabel, | |||
|
|
|||
| private BigDecimal sellItem(final User user, final ItemStack is, final String[] args, final boolean isBulkSell) throws Exception { | |||
| final int amount = ess.getWorth().getAmount(ess, user, is, args, isBulkSell); | |||
| final BigDecimal worth = ess.getWorth().getPrice(ess, is); | |||
| final BigDecimal worth = ess.getWorth().getPrice(ess, is) == null ? null : ess.getWorth().getPrice(ess, is).multiply(ess.getSettings().getMultiplier(user)); | |||
There was a problem hiding this comment.
Suggested change
| final BigDecimal worth = ess.getWorth().getPrice(ess, is) == null ? null : ess.getWorth().getPrice(ess, is).multiply(ess.getSettings().getMultiplier(user)); | |
| final BigDecimal originalWorth = ess.getWorth().getPrice(ess, is); | |
| final BigDecimal worth = originalWorth == null ? null : originalWorth.multiply(ess.getSettings().getMultiplier(user)); |
Comment on lines
+857
to
+862
| # Settings for /sell multipliers | ||
| # Give multipliers to players with the permission 'essentials.sell.multiplier.{multiplier}' | ||
| # example: 'essentials.sell.multiplier.double', 'essentials.sell.multiplier.triple' | ||
| # You can add as many multipliers as you want. | ||
| # Use the "default" name to set the default multiplier that everyone has. It defaults to 1 if not set. | ||
| # If a player has more than one multiplier permission, it will pick the highest one. |
There was a problem hiding this comment.
Suggested change
| # Settings for /sell multipliers | |
| # Give multipliers to players with the permission 'essentials.sell.multiplier.{multiplier}' | |
| # example: 'essentials.sell.multiplier.double', 'essentials.sell.multiplier.triple' | |
| # You can add as many multipliers as you want. | |
| # Use the "default" name to set the default multiplier that everyone has. It defaults to 1 if not set. | |
| # If a player has more than one multiplier permission, it will pick the highest one. | |
| # Allow players to receive multipliers for items sold with /sell or the sell sign. | |
| # You can set the default multiplier using the 'default' rank below. | |
| # To grant different multipliers to different people, you need to define a 'multiplier-rank' below. | |
| # Create the 'multiplier-rank' below, and give the matching permission: essentials.sell.multiplier.<multiplier-rank> |
|
Can we please get sell multipliers implemented to latest essentialsx? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #3934
Details
Proposed feature:
Sell multipliers! The idea is for servers to be able to control how much players can /sell their items for based on configurable permissions. I re-wrote this based on @Chew's feedback to work more similarly to the multiple set-home system so that it doesn't have to iterate over all of a players' permissions and instead, check if they have the ones in the config.
#3934
Environments tested:
OS: Windows 10
Java version: OpenJDK 17.0.1
Demonstration:
Screenshot: https://i.imgur.com/ju0jMUy.png
Here I give myself a diamond and sell it with no permissions (as op), then I give myself the "essentials.sell.multiplier.double" permission and as you can see, my sell price is double.
Plugin Download: https://www.dropbox.com/s/56y3zf6ibarlwj4/EssentialsX-2.19.3-dev%2B6-739600e-sell-multipliers-redo.jar?dl=0