Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pagination style "infinite" #121

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ckosmowski
Copy link
Collaborator

  • Added the ability to use fetchers that do not implement a count() method. The property "paginationStyle" as suggested in Add pagination strategies to support count()-less remote fetching #120 must be set to "infinite" to allow fetchers without
    a count method.
  • Added the option "infinitePageSize" to control the amount of data that should be retrieved an each scroll event. If undefined defaults to the amount of rows that fit into one viewPort page
  • Modified some checks, so the fetchers without count methods can work without having placeholders in the table

- Added the ability to use fetchers that do not implement a count() method. The property "paginationStyle" as suggested in EvHaus#120 must be set to "infinite" to allow fetchers without
a count method.

- Added the option "infinitePageSize" to control the amount of data that should be retrieved an each scroll event. If undefined defaults to the amount of rows that fit into one viewPort page

- Modified some checks, so the fetchers without count methods can work without having placeholders in the table
@ckosmowski
Copy link
Collaborator Author

I tried to add the "infinite" pagination style as i need it. I'm using it together with a Backbone collection as a data source and it works out pretty well for me. I did not test groups and variable row heights yet.

@EvHaus EvHaus added this to the Future milestone Aug 21, 2014
@EvHaus EvHaus self-assigned this Aug 21, 2014
};

var fetch = function (options, callback) {
console.log(options);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove this console.log

@ckosmowski
Copy link
Collaborator Author

From your comments: I'm not really sure if this solution fit's the doby-grid projects general needs at all. Maybe it would be best to start again for this feature with the knowledge you have about the code and especially the dependencies that methods and features have to each other.

For example i'm also experiencing that this changes won't really work well with sorting. After sorting and a successfull fetch the results of this fetch won't be displayed anymore. I feel like i'm kind of tangled up with the code for this feature. (I added some further changes locally but it's rather getting worse).

@EvHaus
Copy link
Owner

EvHaus commented Aug 22, 2014

No problem. I'll keep this PR open so I can use it as a reference for what you're after when we start working on the feature.

@EvHaus EvHaus added ready and removed in progress labels Dec 19, 2014
@EvHaus EvHaus removed their assignment Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants