-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added pagination style "infinite" #121
base: master
Are you sure you want to change the base?
Conversation
- Added the ability to use fetchers that do not implement a count() method. The property "paginationStyle" as suggested in EvHaus#120 must be set to "infinite" to allow fetchers without a count method. - Added the option "infinitePageSize" to control the amount of data that should be retrieved an each scroll event. If undefined defaults to the amount of rows that fit into one viewPort page - Modified some checks, so the fetchers without count methods can work without having placeholders in the table
I tried to add the "infinite" pagination style as i need it. I'm using it together with a Backbone collection as a data source and it works out pretty well for me. I did not test groups and variable row heights yet. |
}; | ||
|
||
var fetch = function (options, callback) { | ||
console.log(options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to remove this console.log
From your comments: I'm not really sure if this solution fit's the doby-grid projects general needs at all. Maybe it would be best to start again for this feature with the knowledge you have about the code and especially the dependencies that methods and features have to each other. For example i'm also experiencing that this changes won't really work well with sorting. After sorting and a successfull fetch the results of this fetch won't be displayed anymore. I feel like i'm kind of tangled up with the code for this feature. (I added some further changes locally but it's rather getting worse). |
No problem. I'll keep this PR open so I can use it as a reference for what you're after when we start working on the feature. |
a count method.