-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review #2764
Open
warquys
wants to merge
19
commits into
Exiled-Team:dev
Choose a base branch
from
warquys:Review
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Review #2764
Commits on Aug 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1841bbb - Browse repository at this point
Copy the full SHA 1841bbbView commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ca767b - Browse repository at this point
Copy the full SHA 2ca767bView commit details -
Simplifying Singleton<T> implementation
The code has been simplified to no longer use a dictionary to manage multiple instances of `Singleton<T>`. Now a single instance of `T` is used via a static `Instance` property. The `Create` method has been changed to set the instance if it is not already set, and a new `Destroy` method has been added to reset the instance to `null`. The `TryGet` and `Destroy` methods have been simplified to work with the new single instance implementation. The calls to `Singleton<VirtualPlugin>.Create(this)` and `Singleton<VirtualPlugin>.Destroy(this)` in `VirtualPlugin.cs` have been commented out, with annotations suggesting that use of the class itself as a singleton might require a different approach to avoid overwriting other instances.
Configuration menu - View commit details
-
Copy full SHA for 0c47b98 - Browse repository at this point
Copy the full SHA 0c47b98View commit details
Commits on Sep 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 363913a - Browse repository at this point
Copy the full SHA 363913aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e9f65f - Browse repository at this point
Copy the full SHA 5e9f65fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5eb750 - Browse repository at this point
Copy the full SHA b5eb750View commit details -
Simplifying Singleton<T> implementation
The code has been simplified to no longer use a dictionary to manage multiple instances of `Singleton<T>`. Now a single instance of `T` is used via a static `Instance` property. The `Create` method has been changed to set the instance if it is not already set, and a new `Destroy` method has been added to reset the instance to `null`. The `TryGet` and `Destroy` methods have been simplified to work with the new single instance implementation. The calls to `Singleton<VirtualPlugin>.Create(this)` and `Singleton<VirtualPlugin>.Destroy(this)` in `VirtualPlugin.cs` have been commented out, with annotations suggesting that use of the class itself as a singleton might require a different approach to avoid overwriting other instances.
Configuration menu - View commit details
-
Copy full SHA for 104c113 - Browse repository at this point
Copy the full SHA 104c113View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d736ff - Browse repository at this point
Copy the full SHA 4d736ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3a9dd5 - Browse repository at this point
Copy the full SHA c3a9dd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e9555c - Browse repository at this point
Copy the full SHA 1e9555cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e3ef36 - Browse repository at this point
Copy the full SHA 9e3ef36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 934754b - Browse repository at this point
Copy the full SHA 934754bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4439cfa - Browse repository at this point
Copy the full SHA 4439cfaView commit details -
Remove IComparable and Rewrite Euqality/Comparaison form UnmanagedEnu…
…mClass, UniqueUnmagedEnumClass and EnumClass if a IComparable class i needed the Comparer<ExiledEnumClass>.Default provide one.
Configuration menu - View commit details
-
Copy full SHA for c62918b - Browse repository at this point
Copy the full SHA c62918bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6a7cae - Browse repository at this point
Copy the full SHA c6a7caeView commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cc01fdf - Browse repository at this point
Copy the full SHA cc01fdfView commit details
Commits on Nov 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1622c67 - Browse repository at this point
Copy the full SHA 1622c67View commit details -
Configuration menu - View commit details
-
Copy full SHA for f56d761 - Browse repository at this point
Copy the full SHA f56d761View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1229148 - Browse repository at this point
Copy the full SHA 1229148View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.