Skip to content

Commit

Permalink
Merge pull request #37161 from Expensify/revert-37036-video-player-fo…
Browse files Browse the repository at this point in the history
…llowups/app-returns-to-previous-thread-when-pressed-on-video

[CP Staging] Revert "Fix app returns to previous thread when scrubbing video in thread"
  • Loading branch information
chiragsalian authored Feb 23, 2024
2 parents cad3114 + 55d92d5 commit 07681d4
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/components/VideoPlayer/BaseVideoPlayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,7 @@ function BaseVideoPlayer({
}, [bindFunctions, currentVideoPlayerRef, currentlyPlayingURL, isSmallScreenWidth, originalParent, sharedElement, shouldUseSharedVideoElement, url]);

return (
// We need to wrap the video component in a component that will catch unhandled pointer events. Otherwise, these
// events will bubble up the tree, and it will cause unexpected press behavior.
<PressableWithoutFeedback
accessibilityRole="button"
style={styles.flex1}
>
<>
<View style={style}>
<Hoverable>
{(isHovered) => (
Expand Down Expand Up @@ -252,7 +247,7 @@ function BaseVideoPlayer({
hidePopover={hidePopoverMenu}
anchorPosition={popoverAnchorPosition}
/>
</PressableWithoutFeedback>
</>
);
}

Expand Down

0 comments on commit 07681d4

Please sign in to comment.