Skip to content

Commit

Permalink
Addressed to reviewer comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Shahe Shahinyan committed Mar 6, 2024
1 parent ec77c7c commit 2daf9dc
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ function MoneyRequestPreviewContent({
const violationMessage = ViolationsUtils.getViolationTranslation(violations[0], translate);
const violationsCount = violations.filter((v) => v.type === 'violation').length;
const isTooLong = violationsCount > 1 || violationMessage.length > 15;
const hasViolationAndFieldErrors = violationsCount === 1 && hasFieldErrors;
const hasViolationsAndFieldErrors = violationsCount > 0 && hasFieldErrors;

Check failure on line 160 in src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

View workflow job for this annotation

GitHub Actions / Run ESLint

'hasViolationsAndFieldErrors' is assigned a value but never used

return `${message}${isTooLong || hasViolationAndFieldErrors ? translate('violations.reviewRequired') : violationMessage}`;

Check failure on line 162 in src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

View workflow job for this annotation

GitHub Actions / typecheck

Cannot find name 'hasViolationAndFieldErrors'. Did you mean 'hasViolationsAndFieldErrors'?
}
Expand Down

0 comments on commit 2daf9dc

Please sign in to comment.