Skip to content

Commit

Permalink
Merge pull request #41152 from brunovjk/fix/39559
Browse files Browse the repository at this point in the history
Fix reintroduced dependencies from conflict resolution
  • Loading branch information
bondydaa authored Apr 30, 2024
2 parents 54d971a + 9c70d9d commit 33543a6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/components/MoneyRequestConfirmationList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ function MoneyRequestConfirmationList({
return;
}
IOU.setMoneyRequestCategory(transactionID, enabledCategories[0].name);
// Keep 'transaction' out to ensure that we autoselect the option only once
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [shouldShowCategories, policyCategories, isCategoryRequired]);

Expand All @@ -552,7 +553,9 @@ function MoneyRequestConfirmationList({
if (updatedTagsString !== TransactionUtils.getTag(transaction) && updatedTagsString) {
IOU.setMoneyRequestTag(transactionID, updatedTagsString);
}
}, [policyTagLists, transaction, transactionID, policyTags, canUseViolations]);
// Keep 'transaction' out to ensure that we autoselect the option only once
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [policyTagLists, policyTags, canUseViolations]);

/**
*/
Expand Down

0 comments on commit 33543a6

Please sign in to comment.