Skip to content

Commit

Permalink
Merge pull request #52087 from layacat/fix/50485
Browse files Browse the repository at this point in the history
fix: 50485 mWeb/Chrome - IOU- Continue and green button not working in scan page
  • Loading branch information
Julesssss authored Nov 28, 2024
2 parents 42c6a30 + e60bbb9 commit 43640b1
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,24 @@ Yes, you can edit an expense until it is paid. When an expense is submitted, the
In Expensify, expense reports group expenses in a batch to be paid or reconciled. When a draft report is open, all new expenses are added to it.

Once a report is submitted, you can track the status from the **Search** section. Click the **View** button for a specific expense or expense report. The status is displayed at the top of the expense or report.

**How can I enable camera permission for a website on mobile browsers?**

**Google Chrome:**
1. Open Chrome.
2. To the right of the address bar, tap More icon > **Settings**.
3. Tap **Site settings** > **Camera**.
4. Tap to turn the microphone or camera on or off.
- If you find the site you want to use under **Blocked**, tap the site > **Allow**.
5. Refresh the site.

**Safari:**
1. Open Safari.
2. To the left of the address bar, tap More icon > **Site settings** > **Camera**.
3. Tap **Allow** to grant permission.
4. Tap **Done**.
5. Refresh the site.

{% include faq-end.md %}

</div>
2 changes: 2 additions & 0 deletions src/CONST.ts
Original file line number Diff line number Diff line change
Expand Up @@ -911,6 +911,8 @@ const CONST = {
NEWHELP_URL: 'https://help.expensify.com',
INTERNAL_DEV_EXPENSIFY_URL: 'https://www.expensify.com.dev',
STAGING_EXPENSIFY_URL: 'https://staging.expensify.com',
DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL:
'https://help.expensify.com/articles/new-expensify/expenses-&-payments/Create-an-expense#:~:text=How%20can%20I%20enable%20camera%20permission%20on%20mobile%20browser%3F',
BANK_ACCOUNT_PERSONAL_DOCUMENTATION_INFO_URL:
'https://community.expensify.com/discussion/6983/faq-why-do-i-need-to-provide-personal-documentation-when-setting-up-updating-my-bank-account',
PERSONAL_DATA_PROTECTION_INFO_URL: 'https://community.expensify.com/discussion/5677/deep-dive-security-how-expensify-protects-your-information',
Expand Down
2 changes: 2 additions & 0 deletions src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -793,6 +793,8 @@ const translations = {
chooseReceipt: 'Choose a receipt to upload or forward a receipt to ',
takePhoto: 'Take a photo',
cameraAccess: 'Camera access is required to take pictures of receipts.',
deniedCameraAccess: "Camera access still hasn't been granted, please follow ",
deniedCameraAccessInstructions: 'these instructions',
cameraErrorTitle: 'Camera error',
cameraErrorMessage: 'An error occurred while taking a photo. Please try again.',
locationAccessTitle: 'Allow location access',
Expand Down
2 changes: 2 additions & 0 deletions src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -788,6 +788,8 @@ const translations = {
chooseReceipt: 'Elige un recibo para subir o reenvía un recibo a ',
takePhoto: 'Haz una foto',
cameraAccess: 'Se requiere acceso a la cámara para hacer fotos de los recibos.',
deniedCameraAccess: 'No se ha concedido el acceso a la cámara, siga ',
deniedCameraAccessInstructions: 'estas instrucciones',
cameraErrorTitle: 'Error en la cámara',
locationAccessTitle: 'Permitir acceso a la ubicación',
locationAccessMessage: 'El acceso a la ubicación nos ayuda a mantener tu zona horaria y moneda precisas dondequiera que vayas.',
Expand Down
10 changes: 9 additions & 1 deletion src/pages/iou/request/step/IOURequestStepScan/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import LocationPermissionModal from '@components/LocationPermissionModal';
import PDFThumbnail from '@components/PDFThumbnail';
import PressableWithFeedback from '@components/Pressable/PressableWithFeedback';
import Text from '@components/Text';
import TextLink from '@components/TextLink';
import withCurrentUserPersonalDetails from '@components/withCurrentUserPersonalDetails';
import useLocalize from '@hooks/useLocalize';
import usePolicy from '@hooks/usePolicy';
Expand Down Expand Up @@ -638,7 +639,14 @@ function IOURequestStepScan({
additionalStyles={[styles.pb5]}
/>
<Text style={[styles.textFileUpload]}>{translate('receipt.takePhoto')}</Text>
<Text style={[styles.subTextFileUpload]}>{translate('receipt.cameraAccess')}</Text>
{cameraPermissionState === 'denied' ? (
<Text style={[styles.subTextFileUpload]}>
{translate('receipt.deniedCameraAccess')}
<TextLink href={CONST.DENIED_CAMERA_ACCESS_INSTRUCTIONS_URL}>{translate('receipt.deniedCameraAccessInstructions')}</TextLink>.
</Text>
) : (
<Text style={[styles.subTextFileUpload]}>{translate('receipt.cameraAccess')}</Text>
)}
<Button
success
text={translate('common.continue')}
Expand Down

0 comments on commit 43640b1

Please sign in to comment.