e2e: exclude warmup results from final measurements

Expensify · Jun 4, 2024 · d20326b · d20326b
1 parent 1d5f83d
commit d20326b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/tests/e2e/server/index.ts b/tests/e2e/server/index.ts
@@ -28,6 +28,7 @@ type ServerInstance = {
     addTestResultListener: AddListener<TestResultListener>;
     addTestDoneListener: AddListener<TestDoneListener>;
     forceTestCompletion: () => void;
+    setReadyToAcceptTestResults: (isReady: boolean) => void;
     start: () => Promise<void>;
     stop: () => Promise<Error | undefined>;
 };
@@ -96,6 +97,11 @@ const createServerInstance = (): ServerInstance => {
     const [testStartedListeners, addTestStartedListener] = createListenerState<TestStartedListener>();
     const [testResultListeners, addTestResultListener] = createListenerState<TestResultListener>();
     const [testDoneListeners, addTestDoneListener] = createListenerState<TestDoneListener>();
+    let isReadyToAcceptTestResults = true;
+
+    const setReadyToAcceptTestResults = (isReady: boolean) => {
+        isReadyToAcceptTestResults = isReady;
+    };
 
     const forceTestCompletion = () => {
         testDoneListeners.forEach((listener) => {
@@ -122,6 +128,10 @@ const createServerInstance = (): ServerInstance => {
             }
 
             case Routes.testResults: {
+                if (!isReadyToAcceptTestResults) {
+                    return res.end('ok');
+                }
+
                 getPostJSONRequestData<TestResult>(req, res)?.then((data) => {
                     if (!data) {
                         // The getPostJSONRequestData function already handled the response
@@ -201,6 +211,7 @@ const createServerInstance = (): ServerInstance => {
     });
 
     return {
+        setReadyToAcceptTestResults,
         setTestConfig,
         addTestStartedListener,
         addTestResultListener,

diff --git a/tests/e2e/testRunner.ts b/tests/e2e/testRunner.ts
@@ -178,6 +178,7 @@ const runTests = async (): Promise<void> => {
         await sleep(config.BOOT_COOL_DOWN);
 
         server.setTestConfig(test as TestConfig);
+        server.setReadyToAcceptTestResults(false);
 
         const warmupText = `Warmup for test '${test.name}' [${testIndex + 1}/${tests.length}]`;
 
@@ -193,6 +194,8 @@ const runTests = async (): Promise<void> => {
             await runTestIteration(config.DELTA_APP_PACKAGE, `[DELTA] ${warmupText}. Iteration ${i + 1}/${iterations}`);
         }
 
+        server.setReadyToAcceptTestResults(true);
+
         // For each test case we allow the test to fail three times before we stop the test run:
         const errorCountRef = {
             errorCount: 0,