Action linter

Expensify · Dec 2, 2024 · d7a73ca · d7a73ca
1 parent 7ad51a8
commit d7a73ca
Show file tree

Hide file tree

Showing 3 changed files with 62 additions and 13 deletions.
diff --git a/.github/actions/javascript/postTestBuildComment/index.js b/.github/actions/javascript/postTestBuildComment/index.js
@@ -11533,11 +11533,11 @@ function getTestBuildMessage() {
     const message = `:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:
 | Android :robot:  | iOS :apple: |
 | ------------- | ------------- |
-| ${result['ANDROID'].link}  | ${result['IOS'].link}  |
-| ${result['ANDROID'].qrCode}  | ${result['IOS'].qrCode}  |
+| ${result.ANDROID.link}  | ${result.IOS.link}  |
+| ${result.ANDROID.qrCode}  | ${result.IOS.qrCode}  |
 | Desktop :computer: | Web :spider_web: |
-| ${result['DESKTOP'].link}  | ${result['WEB'].link}  |
-| ${result['DESKTOP'].qrCode}  | ${result['WEB'].qrCode}  |
+| ${result.DESKTOP.link}  | ${result.WEB.link}  |
+| ${result.DESKTOP.qrCode}  | ${result.WEB.qrCode}  |
 
 ---
 

diff --git a/.github/actions/javascript/postTestBuildComment/postTestBuildComment.ts b/.github/actions/javascript/postTestBuildComment/postTestBuildComment.ts
@@ -1,5 +1,6 @@
 import * as core from '@actions/core';
 import {context} from '@actions/github';
+import {TupleToUnion} from 'type-fest';
 import CONST from '@github/libs/CONST';
 import GithubUtils from '@github/libs/GithubUtils';
 
@@ -36,16 +37,16 @@ function getTestBuildMessage(): string {
                 qrCode,
             },
         };
-    }, {} as Record<(typeof inputs)[number], {link: string; qrCode: string}>);
+    }, {} as Record<TupleToUnion<typeof inputs>, {link: string; qrCode: string}>);
 
     const message = `:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:
 | Android :robot:  | iOS :apple: |
 | ------------- | ------------- |
-| ${result['ANDROID'].link}  | ${result['IOS'].link}  |
-| ${result['ANDROID'].qrCode}  | ${result['IOS'].qrCode}  |
+| ${result.ANDROID.link}  | ${result.IOS.link}  |
+| ${result.ANDROID.qrCode}  | ${result.IOS.qrCode}  |
 | Desktop :computer: | Web :spider_web: |
-| ${result['DESKTOP'].link}  | ${result['WEB'].link}  |
-| ${result['DESKTOP'].qrCode}  | ${result['WEB'].qrCode}  |
+| ${result.DESKTOP.link}  | ${result.WEB.link}  |
+| ${result.DESKTOP.qrCode}  | ${result.WEB.qrCode}  |
 
 ---
 

diff --git a/tests/unit/postTestBuildComment.ts b/tests/unit/postTestBuildComment.ts
@@ -62,18 +62,34 @@ const message = `:test_tube::test_tube: Use the links below to test this adhoc b
 :eyes: [View the workflow run that generated this build](https://github.com/Expensify/App/actions/runs/1234) :eyes:
 `;
 
+const onlyAndroidMessage = `:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:
+| Android :robot:  | iOS :apple: |
+| ------------- | ------------- |
+| ${androidLink}  | N/A  |
+| ${androidQRCode}  | N/A  |
+| Desktop :computer: | Web :spider_web: |
+| N/A  | N/A  |
+| N/A  | N/A  |
+
+---
+
+:eyes: [View the workflow run that generated this build](https://github.com/Expensify/App/actions/runs/1234) :eyes:
+`;
+
 describe('Post test build comments action tests', () => {
     beforeAll(() => {
         // Mock core module
         asMutable(core).getInput = mockGetInput;
     });
 
+    beforeEach(() => jest.clearAllMocks());
+
     test('Test GH action', async () => {
         when(core.getInput).calledWith('PR_NUMBER', {required: true}).mockReturnValue('12');
-        when(core.getInput).calledWith('ANDROID', {required: true}).mockReturnValue('success');
-        when(core.getInput).calledWith('IOS', {required: true}).mockReturnValue('success');
-        when(core.getInput).calledWith('WEB', {required: true}).mockReturnValue('success');
-        when(core.getInput).calledWith('DESKTOP', {required: true}).mockReturnValue('success');
+        when(core.getInput).calledWith('ANDROID', {required: false}).mockReturnValue('success');
+        when(core.getInput).calledWith('IOS', {required: false}).mockReturnValue('success');
+        when(core.getInput).calledWith('WEB', {required: false}).mockReturnValue('success');
+        when(core.getInput).calledWith('DESKTOP', {required: false}).mockReturnValue('success');
         when(core.getInput).calledWith('ANDROID_LINK').mockReturnValue('https://expensify.app/ANDROID_LINK');
         when(core.getInput).calledWith('IOS_LINK').mockReturnValue('https://expensify.app/IOS_LINK');
         when(core.getInput).calledWith('WEB_LINK').mockReturnValue('https://expensify.app/WEB_LINK');
@@ -102,4 +118,36 @@ describe('Post test build comments action tests', () => {
         expect(createCommentMock).toBeCalledTimes(1);
         expect(createCommentMock).toBeCalledWith('App', 12, message);
     });
+
+    test('Test GH action when input is not complete', async () => {
+        when(core.getInput).calledWith('PR_NUMBER', {required: true}).mockReturnValue('12');
+        when(core.getInput).calledWith('ANDROID', {required: false}).mockReturnValue('success');
+        when(core.getInput).calledWith('IOS', {required: false}).mockReturnValue('');
+        when(core.getInput).calledWith('WEB', {required: false}).mockReturnValue('');
+        when(core.getInput).calledWith('DESKTOP', {required: false}).mockReturnValue('');
+        when(core.getInput).calledWith('ANDROID_LINK').mockReturnValue('https://expensify.app/ANDROID_LINK');
+        createCommentMock.mockResolvedValue({} as CreateCommentResponse);
+        mockListComments.mockResolvedValue({
+            data: [
+                {
+                    body: ':test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing!',
+                    // eslint-disable-next-line @typescript-eslint/naming-convention
+                    node_id: 'IC_abcd',
+                },
+            ],
+        });
+        await ghAction();
+        expect(mockGraphql).toBeCalledTimes(1);
+        expect(mockGraphql).toBeCalledWith(`
+            mutation {
+              minimizeComment(input: {classifier: OUTDATED, subjectId: "IC_abcd"}) {
+                minimizedComment {
+                  minimizedReason
+                }
+              }
+            }
+        `);
+        expect(createCommentMock).toBeCalledTimes(1);
+        expect(createCommentMock).toBeCalledWith('App', 12, onlyAndroidMessage);
+    });
 });