[HOLD for payment 2023-09-04] Task -App becomes unresponsive when Assign Task to user that doesn't have a NewDot account yet

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to FAB > Assign Task > Enter title and description and navigate to next page
3. Click on Assignee
4. Enter a email that doesn't have a NewDot account yet
5. Create the task

Expected Result:

Assignee should be added immediately and no errors should appears

Actual Result:

App becomes unresponsive when Assign Task to user that doesn't have a NewDot account yet
Page Unresponsive
You can wait for it to become responsive or exit the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows / Chrome
• MacOS / Desktop

Version Number: 1.3.56-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6173285_Recording__776.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcochavezf]

Seems we're entering an infinite loop after assigning the task

[marcochavezf]

We're calling multiple times componentDidUpdate in ReportScreen.js

Screen.Recording.2023-08-22.at.14.20.50.mov

I will need to step out for 1.5 hours approx, I will continue when I come back

[marcochavezf]

The OpenReport and CreateTask are failing:

[marcaaron]

Doing the repro steps for this is causing a crazy infinite loop that crashes the browser for me. Happens on both production API and staging API.

It's pretty bad. The app becomes unusable.

[marcaaron]

These three PRs are related to tasks:

#24506
#24412
#24566

Not sure if any of them are related to this regression. @Julesssss @arosiclair @luacmartins might have a better idea.

[marcaaron]

FWIW, this flow doesn't actually work on production either cc @thienlnam

Assignee should be added immediately and no errors should appears

This is not what happens on production. I see this:

And CreateTask throws an error about 400 Invalid accountID

[marcaaron]

This issue appears to be resolved after applying the revert from here #25785

[marcaaron]

Chatting with @thienlnam.

Seems like if we are not going to revert the unread marker PR as per #25673 (comment) then we should do some other work around that prevents taking this action entirely when assigning a task.

It's not possible in the backend so I think seems like a "feature request" or polish step for Tasks.

[roryabraham]

Confirmed that this is no longer reproducible on staging and that the PR worked. Removing the deploy blocker label and checking this off.

Should we create a follow-up to enable you to assign tasks to accounts that don't exist yet? I feel like that's more inline with how other flows such as New Chat work and is a viral growth flow.

[thienlnam]

Yeah I can create a follow up PR - hasn't been a priority but a good polish item

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP staging] Disable assigning users who do not yet exist to tasks #25806

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[marcaaron]

This appears to be an internal effort (all) so I think we can close it.