[HOLD for payment 2024-02-26] [$500] [MEDIUM] Android - Scan - Icons in Scan receipt context menu appear after delay

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.28.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to 1:1 DM.
2. Create a Scan request using receipt taken via device camera.
3. Navigate to request details page.
4. Manually enter the amount.
5. Tap to open the receipt.
6. Tap 3-dot menu while the receipt is still loading.

Expected Result:

The icons for Replace, Download and Delete receipt in the context menu will appear without delay.

Actual Result:

The icons for Replace, Download and Delete receipt in the context menu appear after delay.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6349480_1705851168741.Screen_Recording_20240121_232125_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d26562fb0814a7b3
• Upwork Job ID: 1749421771987537920
• Last Price Increase: 2024-02-05
• Automatic offers:
• ikevin127 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d26562fb0814a7b3

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[kbecciv]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[zanyrenney]

Hey thanks @kbecciv let me check with Dylan!

[dylanexpensify]

agree!

[zanyrenney]

it's been moved over, all good here. waiting on proposals!

[eVoloshchak]

Not overdue, waiting on proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

awaiting propopsals.

[melvin-bot]

@eVoloshchak @zanyrenney this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[zanyrenney]

bumped in open source room here https://expensify.slack.com/archives/C01GTK53T8Q/p1707218950335999

[MonilBhavsar]

Thanks for the comparison and thoughts!

We're only adding this logic to the index.native.tsx of the ImageSVG component, therefore only for native devices.

Since the issue only happens with Android. How are we feeling about making change only to Android? Let's make sure we don't add regression to iOS.

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ikevin127]

Since the issue only happens with Android. How are we feeling about making change only to Android? Let's make sure we don't add regression to iOS.

@MonilBhavsar Sure, would it be acceptable if I simply clone the current index.native.tsx which has a total of 21 lines:

App/src/components/ImageSVG/index.native.tsx

Line 1 in 6a0e7ed

import {Image} from 'expo-image';

and rename one to index.ios.tsx and the other to index.android.tsx, adding the mentioned logic only to Android ?

[MonilBhavsar]

Yes, that's the way I can also think of 👍

[ikevin127]

@eVoloshchak PR #36275 ready for review! 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Android - Scan - Icons in Scan receipt context menu appear after delay #36275

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @ikevin127 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[zanyrenney]

hey there

i can't get the offer to load for the payment, looking into it but sorry for the delay!

[zanyrenney]

@eVoloshchak requires payment through NewDot Manual Requests - please request $500
@ikevin127 requires payment automatic offer (Contributor) - paid $500 through upwork.

thanks!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: there isn't a PR that has caused this, this was caused by images taking too long to load and not being cached
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed here, this is a simple visual bug
• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? No
  Is it an impactful bug? No
  The bug is very minor and has zero impact on user experience, I don't think a regression test is needed here

[JmillsExpensify]

$500 approved for @eVoloshchak based on this comment.