[HOLD for payment 2024-02-09] [$500] Task – Unable to change assignee twice when edit a task Offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.35-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4262665
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Create a task with assignee
4. Open task details page and go Offline
5. Change the assignee to another
6. Change the assignee to another one more time

Expected Result:

Assignee from the step 6 is displayed

Actual Result:

Assignee from the step 5 is displayed. Unable to change assignee twice when edit a task Offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6363838_1706805779794.Unable_to_change_assignee_twice_when_edit_a_task_Offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e8af7391b7bbb42a
• Upwork Job ID: 1753172040869830656
• Last Price Increase: 2024-02-01
• Automatic offers:
• mkhutornyi | Contributor | 28135627

Issue Owner

Current Issue Owner: @kadiealexander

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task – Unable to change assignee twice when edit a task Offline

What is the root cause of that problem?

App/src/components/ReportActionItem/TaskView.tsx

Lines 157 to 162 in 31948fb

	{report.managerID ? (
	<OfflineWithFeedback pendingAction={report.pendingFields?.managerID}>
	<MenuItem
	label={translate('task.assignee')}
	title={ReportUtils.getDisplayNameForParticipant(report.managerID)}
	icon={OptionsListUtils.getAvatarsForAccountIDs(report.managerID ? [report.managerID] : [], personalDetails)}

managerID is task assignee here but this component is not re-rendered whenever managerID is updated because of memoization below:

App/src/pages/home/report/ReportActionsView.js

Lines 317 to 324 in 12cf5dc

	return (
	oldProps.report.lastReadTime === newProps.report.lastReadTime &&
	oldProps.report.reportID === newProps.report.reportID &&
	oldProps.report.policyID === newProps.report.policyID &&
	oldProps.report.lastVisibleActionCreated === newProps.report.lastVisibleActionCreated &&
	oldProps.report.isOptimisticReport === newProps.report.isOptimisticReport &&
	_.isEqual(oldProps.report.pendingFields, newProps.report.pendingFields)
	);

App/src/pages/home/ReportScreen.js

Lines 649 to 669 in 12cf5dc

	memo(
	ReportScreen,
	(prevProps, nextProps) =>
	prevProps.isSidebarLoaded === nextProps.isSidebarLoaded &&
	_.isEqual(prevProps.reportActions, nextProps.reportActions) &&
	_.isEqual(prevProps.reportMetadata, nextProps.reportMetadata) &&
	prevProps.isComposerFullSize === nextProps.isComposerFullSize &&
	_.isEqual(prevProps.betas, nextProps.betas) &&
	_.isEqual(prevProps.policies, nextProps.policies) &&
	prevProps.accountManagerReportID === nextProps.accountManagerReportID &&
	prevProps.userLeavingStatus === nextProps.userLeavingStatus &&
	prevProps.report.reportID === nextProps.report.reportID &&
	prevProps.report.policyID === nextProps.report.policyID &&
	prevProps.report.isOptimisticReport === nextProps.report.isOptimisticReport &&
	prevProps.report.statusNum === nextProps.report.statusNum &&
	_.isEqual(prevProps.report.pendingFields, nextProps.report.pendingFields) &&
	prevProps.currentReportID === nextProps.currentReportID &&
	prevProps.report.notificationPreference === nextProps.report.notificationPreference &&
	prevProps.report.isPinned === nextProps.report.isPinned &&
	prevProps.report.chatReportID === nextProps.report.chatReportID,
	),

What changes do you think we should make in order to solve the problem?

add report.managerID check in those 2 places

[grgia]

@hurali97 it seems your PR #30168 may have caused this regression

Are you able to push a follow up or shall we test the above proposal?

cc @aimane-chnaif @mountiny

[mountiny]

@grgia I can help take over, indeed that is coming from the PR thank you for the heads up!

[mountiny]

@mkhutornyi are you able to raise the PR now? is $250 fine with you? The change is simple and same as in couple other fixes so adjusting price given the low complaxity

[mkhutornyi]

sure thanks

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e8af7391b7bbb42a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@mkhutornyi please feel free to raise the PR!

[mountiny]

@mkhutornyi please ping me in slack when you have the PR ready!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.35-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix assignee is not updated immediately #35598

If no regressions arise, payment will be issued on 2024-02-09. 🎊

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment (Needs manual offer from BZ)
• @mkhutornyi requires payment automatic offer (Contributor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @kadiealexander you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

@mountiny, @grgia, @kadiealexander, @aimane-chnaif, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kadiealexander]

Sorry, was OOO! Payouts due:

• Contributor: $500 @mkhutornyi
• Contributor+: none @aimane-chnaif

Upwork job is here.

[aimane-chnaif]

@kadiealexander please cancel my offer. No payment needed for me. Thanks