[HOLD for payment 2024-08-14] [$500][P2P Distance] Create UpdateMoneyRequestDistanceRate in App

[neil-marcellini]

Create UpdateMoneyRequestRate following this plan. Please be sure to read and understand the relevant sections of the entire plan as well.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fde353d38f5fdf1b
• Upwork Job ID: 1760136022052638720
• Last Price Increase: 2024-02-21
• Automatic offers:
• paultsimura | Contributor | 0

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fde353d38f5fdf1b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Once the Distance and Rate are added as separate fields of a Distance request (not stored in a merchant as currently), we want to introduce the possibility to edit the rate once the request is created.

What is the root cause of that problem?

This is a new feature request

What changes do you think we should make in order to solve the problem?

This should be done after the Rate field is added to the Money Requests.

First, we should add the EditRequestRatePage similar to other pages that modify IOU fields (IOURequestStepDescription/IOURequestStepTag) using the WorkspaceRatePage as a UI example.

We need to add the function that will call the BE UpdateMoneyRequestRate API when the page form is submitted. It should use the corresponding parameters that the Endpoint requires, as well as build optimistic data.

What alternative solutions did you explore? (Optional)

[koko57]

Commenting to help with the review.

[neil-marcellini]

@paultsimura's proposal looks good. Sounds like we will hold on #36985, so updating the title for that.

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[paultsimura]

Today's update: I've almost finished the PR. Only final testing remains.

[paultsimura]

The PR is ready: #40021

[stephanieelliott]

PR is awaiting your review @mananjadhav

[mananjadhav]

Thanks for the bump @stephanieelliott. I'll finish this today.

[stephanieelliott]

PR was merged to Main earlier today!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[neil-marcellini]

@stephanieelliott will you please handle payment and then we can close this out?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: Edit Distance Rate flow #40021

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @paultsimura requires payment automatic offer (Contributor)
• @koko57 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @paultsimura] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @paultsimura $500 via Upwork -- PAID
• Contributor+: @mananjadhav $500 via NewDot -- please request

@manjesh-yadav @paultsimura as the last step on this issue, can you please propose a regression test?

Upwork job is here: https://www.upwork.com/jobs/~01fde353d38f5fdf1b

[paultsimura]

@mananjadhav was out sick these days, but I think he'll add the tests here as he was the C+.

[mananjadhav]

Thanks @stephanieelliott. This is more of a feature request so we don't have any offending PR.

Regression Test proposal.

1. Open the app and have a workspace with multiple distance rates.
2. Create a Distance request to the workspace
3. Navigate to the request details page
4. Click the "Rate" field and change the rate
5. Verify the rate & amount are changed correctly
6. Verify the "modified expense" action was added
7. Now, create a Distance request to self via "track expense"
8. Navigate to the request details page
9. Verify the "Rate" field is not clickable

[stephanieelliott]

Thanks @mananjadhav! Regression test issue created here: https://github.com/Expensify/Expensify/issues/421162

[JmillsExpensify]

$500 approved for @mananjadhav