[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [HOLD Mentions v2] Support mentions in editing comments

[puneetlath]

We want to update the edit comment flow to support editing/adding mentions. This does not mean adding support for the auto-complete component. Just parsing the mentions in both directions. This means that when someone goes to edit a comment with a user or report mention we should:

1. convert that from html to markdown so that it can be edited
2. perform the proper markdown to html conversion when the edited comment is saved so that if mentions have been added/removed we properly send that to the API

This is covered in the mentions v2 design doc here.

HOLD for #39549

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[MitchExpensify]

Held on #39549

[war-in]

Hi, I'm Marcin from Software Mansion and I would like to work on this :)

[puneetlath]

Sounds good. Just FYI, the back-end for this hasn't been done yet.

[war-in]

@puneetlath any update on the backend? I think my PR works as expected but would like to get confirmation from your side :)

[puneetlath]

Not yet! Will probably be a few more days before I can start the back-end. Are you ready for a review?

[war-in]

Yup, already marked PR as ready for review, but I wonder if the backend is a blocker for this 🤔 If not I'll notify the reviewer :)

[war-in]

Yup, already marked PR as ready for review, but I wonder if the backend is a blocker for this 🤔 If not I'll notify the reviewer :)

@puneetlath kind bump :)

[puneetlath]

Does it work without the back-end? Like when you refresh the page, is it still shown as mentions?

[war-in]

@puneetlath Yup, you can see it here or in the PR description :)

Screen.Recording.2024-05-13.at.13.10.39.mov

[Beamanator]

@war-in are you aware of some "Cannot read properties of undefined (reading 'accountIDToName')" errors ? I believe a few people are seeing this, not sure exactly the flow

[war-in]

@Beamanator could you give me some details? 🙏 And is it in my PR or do people generally see this error in the app?

[iwiznia]

Putting all the details in slack here https://expensify.slack.com/archives/C04878MDF34/p1715699038416249 please @war-jump there if you can, as this is breaking the app in production

[war-in]

@puneetlath @Beamanator mentioned issue will be resolved in this PR. Can I mark mine as ready for review? I've shown here that it works without the backend

[puneetlath]

Yes, sounds good for me. Let's get it in review.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[puneetlath]

@rlinoz mind confirming that we're all done here?

[rlinoz]

Let's wait until it gets deployed to prod, but also we might have a case we didn't account for #42521 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.84-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Mentions v2] Support mentions in editing comments #40565

If no regressions arise, payment will be issued on 2024-06-24. 🎊

For reference, here are some details about the assignees on this issue:

• @war-in does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@war-in] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[rlinoz]

@eh2077 was the C+

[MitchExpensify]

Payment summary:

• $250 C+ @eh2077 (Upwork)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Mentions v2] Support mentions in editing comments #40565

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @war-in does not require payment (Contractor)
• @eh2077 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eh2077] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

@rlinoz, @MitchExpensify, @war-in, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @war-in is from an agency-contributor and not due payment
• ROLE: @eh2077 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[eh2077]

Checklist

• [@eh2077] Please propose regression test steps to ensure the new feature will work correctly on production in further releases. I'm neutral to add regression test for this feature

Regression test

1. Go to a room
2. Create a comment with user and room mentions
3. Click on Edit comment
4. Verify that all mentions are in the edit view
5. Modify comment by adding at least one user and one room mentions (you can remove some mentions too)
6. Save the comment
7. Verify that all previous and new mentions are there
8. Open some Private notes and verify that editing mentions works correctly

Do we agree 👍 or 👎

[melvin-bot]

@rlinoz, @MitchExpensify, @war-in, @eh2077 Still overdue 6 days?! Let's take care of this!

[MitchExpensify]

@eh2077 Upwork job created here: https://www.upwork.com/jobs/~012066a1fb40a4a923, offer sent!

[MitchExpensify]

Paid and contract ended